Some type-outlives computation tweaks #135007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? oli-obk maybe or re-roll |
oli-obk
approved these changes
Jan 3, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 3, 2025
…=oli-obk Some type-outlives computation tweaks Some tweaks that I wrote when investigating rust-lang#135006. The only commit that's probably interesting here is f364674 (the first commit). For some reason it was concerned with filtering out param-env outlives clauses when they matched item-bound outlives clauses. However, if you look at the rest of the control flow for that function, not filtering out those bounds doesn't actually affect the behavior materially.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) - rust-lang#135061 (crashes: add latest batch of tests) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
Rollup merge of rust-lang#135007 - compiler-errors:outlives-tweaks, r=oli-obk Some type-outlives computation tweaks Some tweaks that I wrote when investigating rust-lang#135006. The only commit that's probably interesting here is f364674 (the first commit). For some reason it was concerned with filtering out param-env outlives clauses when they matched item-bound outlives clauses. However, if you look at the rest of the control flow for that function, not filtering out those bounds doesn't actually affect the behavior materially.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks that I wrote when investigating #135006.
The only commit that's probably interesting here is f364674 (the first commit). For some reason it was concerned with filtering out param-env outlives clauses when they matched item-bound outlives clauses. However, if you look at the rest of the control flow for that function, not filtering out those bounds doesn't actually affect the behavior materially.