rustdoc: treat allowed_through_unstable_modules as deprecation
#135043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures `std::intrinsics::transmute` is deemphasized in the search engine and other UI, by cleaning it into a deprecation without propagating it through reexports when the parent module is stable.
rustbot
added
S-waiting-on-review
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
GuillaumeGomez
approved these changes
Jan 3, 2025
|
Looks good to me, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 3, 2025
…h-unstable-modules-is-a-deprecation-flag, r=GuillaumeGomez rustdoc: treat `allowed_through_unstable_modules` as deprecation This ensures `std::intrinsics::transmute` is deemphasized in the search engine and other UI, by cleaning it into a deprecation without propagating it through reexports when the parent module is stable. Fixes rust-lang#131676 Related to rust-lang#135003 r? `@GuillaumeGomez` `@RalfJung` `@workingjubilee`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) - rust-lang#135061 (crashes: add latest batch of tests) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133420 (Switch rtems target to panic unwind) - rust-lang#134965 (Make Boxy UwU) - rust-lang#135007 (Some type-outlives computation tweaks) - rust-lang#135036 (run-make-support: adjust assertion printing, add some basic sanity checks) - rust-lang#135043 (rustdoc: treat `allowed_through_unstable_modules` as deprecation) - rust-lang#135044 (Improve infer (`_`) suggestions in `const`s and `static`s) - rust-lang#135058 (refactor bootstrap path resolution) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
Rollup merge of rust-lang#135043 - notriddle:notriddle/allowed-through-unstable-modules-is-a-deprecation-flag, r=GuillaumeGomez rustdoc: treat `allowed_through_unstable_modules` as deprecation This ensures `std::intrinsics::transmute` is deemphasized in the search engine and other UI, by cleaning it into a deprecation without propagating it through reexports when the parent module is stable. Fixes rust-lang#131676 Related to rust-lang#135003 r? ``@GuillaumeGomez`` ``@RalfJung`` ``@workingjubilee``
notriddle
deleted the
notriddle/allowed-through-unstable-modules-is-a-deprecation-flag
branch
|
Is the documentation supposed to say just "Deprecated" without further explanation? https://doc.rust-lang.org/nightly/std/intrinsics/fn.transmute.html |
|
A message would indeed be better. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures
std::intrinsics::transmuteis deemphasized in the search engine and other UI, by cleaning it into a deprecation without propagating it through reexports when the parent module is stable.Fixes #131676
Related to #135003
r? @GuillaumeGomez
@RalfJung @workingjubilee