Skip to content

Add tests cases from review of #132289 #135304

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add tests cases from review of #132289 #135304

merged 1 commit into from
Jan 10, 2025

Conversation

steffahn
Copy link
Member

@steffahn steffahn commented Jan 9, 2025

Adding my comments as test-cases as suggested by @jackh726 in #132289 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2025
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (22) The requested URL returned error: 404
curl: (22) The requested URL returned error: 404
ERROR: failed to download llvm from ci

    HELP: There could be two reasons behind this:
        1) The host triple is not supported for `download-ci-llvm`.
        2) Old builds get deleted after a certain time.
    HELP: In either case, disable `download-ci-llvm` in your config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:23

@compiler-errors
Copy link
Member

CI is broken, but this LGTM

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 9, 2025

📌 Commit 5e50518 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned BoxyUwU Jan 9, 2025
@bors
Copy link
Collaborator

bors commented Jan 9, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jan 10, 2025
@workingjubilee
Rollup merge of rust-lang#135304 - steffahn:tests_from_132289, r=comp…
4ac1908 
…iler-errors

Add tests cases from review of rust-lang#132289

Adding my comments as test-cases as suggested by `@jackh726` in rust-lang#132289 (comment)
@workingjubilee workingjubilee mentioned this pull request Jan 10, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 10, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@bors
Auto merge of rust-lang#135319 - matthiaskrgr:rollup-un5lol6, r=matth…
67951d9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133088 (`-Zrandomize-layout` harder. `Foo<T> != Foo<U>`)
 - rust-lang#134619 (Improve prose around `as_slice` example of IterMut)
 - rust-lang#134855 (Add `default_field_values` entry to unstable book)
 - rust-lang#134908 (Fix `ptr::from_ref` documentation example comment)
 - rust-lang#135275 (Add Pin::as_deref_mut to 1.84 relnotes)
 - rust-lang#135294 (Make `bare-fn-no-impl-fn-ptr-99875` test less dependent on path width)
 - rust-lang#135304 (Add tests cases from review of rust-lang#132289)
 - rust-lang#135308 (Make sure to walk into nested const blocks in `RegionResolutionVisitor`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b88aa0 into rust-lang:master Jan 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 10, 2025
@rust-timer
Unrolled build for rust-lang#135304
4b1efa2 
Rollup merge of rust-lang#135304 - steffahn:tests_from_132289, r=compiler-errors

Add tests cases from review of rust-lang#132289

Adding my comments as test-cases as suggested by ``@jackh726`` in rust-lang#132289 (comment)
@steffahn steffahn deleted the tests_from_132289 branch January 10, 2025 17:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@steffahn @rustbot @rust-log-analyzer @compiler-errors @bors @BoxyUwU