Skip to content

Remove generic //@ ignore-{wasm,wasm32,emscripten} in tests #136476

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 3, 2025

Follow-up to #135926.

In favor of capability-based guards //@ needs-{unwind,subprocess}.

Resolves #135923.

r? @ghost

try-job: test-various

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2025
@jieyouxu

This comment was marked as off-topic.

@bors

This comment was marked as off-topic.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
Remove redundant `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

When `//@ needs-{unwind,subprocess}` are the suitable capability guards.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 3, 2025

Er, actually, I should've just deleted them and see what fails first

@jieyouxu jieyouxu added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Feb 3, 2025
@jieyouxu jieyouxu changed the title Remove redundant //@ ignore-{wasm,wasm32,emscripten} in tests Remove generic //@ ignore-{wasm,wasm32,emscripten} in tests Feb 3, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 3, 2025

@bors try

@bors
Copy link
Collaborator

bors commented Feb 3, 2025

⌛ Trying commit cd4c655 with merge 6457c68...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
@bors
Copy link
Collaborator

bors commented Feb 3, 2025

☀️ Try build successful - checks-actions
Build commit: 6457c68 (6457c68086430f4816cae941118652f6363780f3)

@jieyouxu jieyouxu removed the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label Feb 3, 2025
@jieyouxu jieyouxu marked this pull request as ready for review February 3, 2025 14:26
@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 3, 2025

Try-job is green, so @rustbot ready

r? compiler

@jieyouxu jieyouxu added the A-testsuite Area: The testsuite used to check the correctness of rustc label Feb 3, 2025
@lcnr
Copy link
Contributor

lcnr commented Feb 3, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 3, 2025

📌 Commit 190a8a6 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2025
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? `@ghost`

try-job: test-various
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136289 (OnceCell & OnceLock docs: Using (un)initialized consistently)
 - rust-lang#136299 (Ignore NLL boring locals in polonius diagnostics)
 - rust-lang#136411 (Omit argument names from function pointers that do not have argument names)
 - rust-lang#136430 (Use the type-level constant value `ty::Value` where needed)
 - rust-lang#136476 (Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests)
 - rust-lang#136484 (Notes on types/traits used for in-memory query caching)
 - rust-lang#136493 (platform-support: document CPU baseline for x86-32 targets)
 - rust-lang#136498 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f180013 into rust-lang:master Feb 4, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 4, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 4, 2025
Rollup merge of rust-lang#136476 - jieyouxu:panic-panic-panic, r=lcnr

Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests

Follow-up to rust-lang#135926.

In favor of capability-based guards `//@ needs-{unwind,subprocess}`.

Resolves rust-lang#135923.

r? ``@ghost``

try-job: test-various
@jieyouxu jieyouxu deleted the panic-panic-panic branch February 4, 2025 06:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup "no panic support" tests
4 participants