-
Notifications
You must be signed in to change notification settings - Fork 13.4k
tests: fix up new test for nocapture -> capture(none) change #137390
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
This comment has been minimized.
This comment has been minimized.
536c526
to
9a9820e
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if this used some {{.*}}
wildcards. For the purposes of this test, we don't care about optimization attributes, only ABI attributes.
How do I know which attributes are ABI and which ones are optimization? I'm a little out of my depth at that point. |
sret is the only ABI attribute here. |
Same motivation as rust-lang#136287, but for a newly introduced test. Rather than over-constraining here, we just match the sret and accept pretty much all other attributes. @rustbot label llvm-main r? @nikic
9a9820e
to
b41c232
Compare
Went wild with wildcards. LMK if this isn't what you had in mind! |
@bors r+ rollup |
…r=nikic tests: fix up new test for nocapture -> capture(none) change Same change as rust-lang#136287, but for a newly introduced test. `@rustbot` label llvm-main r? `@nikic`
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136503 (Tweak output of const panic diagnostic) - rust-lang#137390 (tests: fix up new test for nocapture -> capture(none) change) - rust-lang#137617 (Introduce `feature(generic_const_parameter_types)`) - rust-lang#137719 (Add missing case explanation for doc inlined re-export of doc hidden item) - rust-lang#137763 (Use `mk_ty_from_kind` a bit less, clean up lifetime handling in borrowck) - rust-lang#137769 (Do not yeet `unsafe<>` from type when formatting unsafe binder) - rust-lang#137776 (Some `rustc_transmute` cleanups) - rust-lang#137800 (Remove `ParamEnv::without_caller_bounds`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#137390 - durin42:llvm-21-nocapture-rename, r=nikic tests: fix up new test for nocapture -> capture(none) change Same change as rust-lang#136287, but for a newly introduced test. ``@rustbot`` label llvm-main r? ``@nikic``
Same change as #136287, but for a newly introduced test.
@rustbot label llvm-main
r? @nikic