Do not yeet unsafe<> from type when formatting unsafe binder
#137769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
rustbot
added
the
S-waiting-on-review
|
Cannot remember if you have r+, so @bors delegate=ymtimi |
|
✌️ @ymtimi, you can now approve this pull request! If @compiler-errors told you to " |
compiler-errors
changed the title
unsafe<> from type when formatting unsafe binder
ytmimi
approved these changes
Feb 28, 2025
|
@bors r+ |
|
@ytmimi: 🔑 Insufficient privileges: Not in reviewers |
|
:/// I typoed your name in the delegate. sorry! @bors r=ytmimi |
bors
added
S-waiting-on-bors
|
All good. This was a nice and simple PR! |
|
Do you know who I need to reach out to in order to get the right privileges to approve PRs? |
|
T-rustfmt should definitely have bors permissions in this repo, at least with the understanding that the permissions will only be used for rustfmt subtree syncs and the occasional in-tree rustfmt PR. You should open a teams PR that adds these lines to |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 1, 2025
…r=ytmimi Do not yeet `unsafe<>` from type when formatting unsafe binder Unsafe binders are types like `unsafe<'a, 'b> Ty<'a, 'b>`. However, users can also specify unsafe binder types with no bound vars, like `unsafe<> Ty`. When I added nightly formatting for unsafe binders, I didn't consider this, so on nightly we are stripping the `unsafe<>` part, which gives us back `Ty` which is a different type! This PR fixes that. r? `@ytmimi`
This was referenced Mar 1, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136503 (Tweak output of const panic diagnostic) - rust-lang#137390 (tests: fix up new test for nocapture -> capture(none) change) - rust-lang#137617 (Introduce `feature(generic_const_parameter_types)`) - rust-lang#137719 (Add missing case explanation for doc inlined re-export of doc hidden item) - rust-lang#137763 (Use `mk_ty_from_kind` a bit less, clean up lifetime handling in borrowck) - rust-lang#137769 (Do not yeet `unsafe<>` from type when formatting unsafe binder) - rust-lang#137776 (Some `rustc_transmute` cleanups) - rust-lang#137800 (Remove `ParamEnv::without_caller_bounds`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2025
Rollup merge of rust-lang#137769 - compiler-errors:empty-unsafe-fmt, r=ytmimi Do not yeet `unsafe<>` from type when formatting unsafe binder Unsafe binders are types like `unsafe<'a, 'b> Ty<'a, 'b>`. However, users can also specify unsafe binder types with no bound vars, like `unsafe<> Ty`. When I added nightly formatting for unsafe binders, I didn't consider this, so on nightly we are stripping the `unsafe<>` part, which gives us back `Ty` which is a different type! This PR fixes that. r? ``@ytmimi``
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsafe binders are types like
unsafe<'a, 'b> Ty<'a, 'b>. However, users can also specify unsafe binder types with no bound vars, likeunsafe<> Ty.When I added nightly formatting for unsafe binders, I didn't consider this, so on nightly we are stripping the
unsafe<>part, which gives us backTywhich is a different type!This PR fixes that.
r? @ytmimi