Skip to content

Implement read_buf for Hermit #138301

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Implement read_buf for Hermit #138301

merged 1 commit into from
Mar 19, 2025

Conversation

thaliaarchi
Copy link
Contributor

Following hermit-os/kernel#1606, it is now safe to implement Read::read_buf for file descriptors on Hermit.

cc @mkroening

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 10, 2025
This was referenced Mar 10, 2025
Open
Merged
mkroening
mkroening approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@bors
Copy link
Collaborator

bors commented Mar 11, 2025

☔ The latest upstream changes (presumably #138302) made this pull request unmergeable. Please resolve the merge conflicts.

@thaliaarchi thaliaarchi force-pushed the io-optional-methods/hermit branch from a372405 to 19b8643 Compare March 11, 2025 05:33
tgross35
tgross35 reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two new unsafe blocks should get SAFETY comments, r=me after that

@thaliaarchi thaliaarchi force-pushed the io-optional-methods/hermit branch from 19b8643 to c5fc193 Compare March 17, 2025 23:55
@thaliaarchi
Copy link
Contributor Author

I've added SAFETY comments.

@tgross35
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 18, 2025

📌 Commit c5fc193 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 18, 2025
@jhpratt
Rollup merge of rust-lang#138301 - thaliaarchi:io-optional-methods/he…
c1f2309 
…rmit, r=tgross35

Implement `read_buf` for Hermit

Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit.

cc `@mkroening`
@jhpratt jhpratt mentioned this pull request Mar 18, 2025
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 18, 2025
@jhpratt
Rollup merge of rust-lang#138301 - thaliaarchi:io-optional-methods/he…
ca789b9 
…rmit, r=tgross35

Implement `read_buf` for Hermit

Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit.

cc ``@mkroening``
@jhpratt jhpratt mentioned this pull request Mar 18, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2025
@bors
Auto merge of rust-lang#138637 - jhpratt:rollup-4bw5bn8, r=jhpratt
6c96bb1 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138508 (Clarify "owned data" in E0515.md)
 - rust-lang#138556 (Fix ICE: attempted to remap an already remapped filename)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138608 (rustc_target: Add target feature constraints for LoongArch)
 - rust-lang#138619 (Flatten `if`s in `rustc_codegen_ssa`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 18, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2025
@bors
Auto merge of rust-lang#138653 - matthiaskrgr:rollup-fwwqmr7, r=matth…
cd7e8c5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors)
 - rust-lang#138642 (Unvacation myself)
 - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2025
@bors
Auto merge of rust-lang#138653 - matthiaskrgr:rollup-fwwqmr7, r=matth…
eed2c22 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors)
 - rust-lang#138642 (Unvacation myself)
 - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2025
@bors
Auto merge of rust-lang#138653 - matthiaskrgr:rollup-fwwqmr7, r=matth…
c4b38a5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors)
 - rust-lang#138642 (Unvacation myself)
 - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 800b8fb into rust-lang:master Mar 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 19, 2025
@thaliaarchi thaliaarchi deleted the io-optional-methods/hermit branch March 19, 2025 18:52
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#138301 - thaliaarchi:io-optional-methods/he…
ae49cc6 
…rmit, r=tgross35

Implement `read_buf` for Hermit

Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit.

cc ```@mkroening```
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 2, 2025
@bors
Auto merge of rust-lang#138653 - matthiaskrgr:rollup-fwwqmr7, r=matth…
9d668f3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136320 (exit: document interaction with C)
 - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`)
 - rust-lang#138301 (Implement `read_buf` for Hermit)
 - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`)
 - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors)
 - rust-lang#138642 (Unvacation myself)
 - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

@mkroening mkroening mkroening approved these changes

Assignees

@tgross35 tgross35

Labels
O-hermit Operating System: Hermit S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thaliaarchi @rustbot @bors @tgross35 @mkroening