-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 9 pull requests #138506
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 9 pull requests #138506
Conversation
Don't suggest explicitly `cfg`-gating `trace!` calls in bootstrap
compiletest directives: ignore-stage0 and only-stage0 do not exist
mention llvm 20 in example prs
already mentioned before showing code snippet
add a pause, for readability
clean --bless text
add missing punctuation
use new terminology
Rewrite effects checking chapter
less text for same effect
Document `fetch.prunetags = true` gotcha during rustc-pull
…lel-queries, r=Mark-Simulacrum,onur-ozkan Remove `RUN_CHECK_WITH_PARALLEL_QUERIES` After rust-lang#132282, I'm pretty sure that this is simply useless? It just runs check with an empty config, lol. CC `@onur-ozkan` r? `@Noratrieb`
remove comment regarding a removed test directive Removed in rust-lang#120265
…anteed-no-drop, r=lcnr Deny impls for `BikeshedGuaranteedNoDrop` r? lcnr
Rustc dev guide subtree update r? `@jieyouxu`
…ieni Pass `CI_JOB_DOC_URL` to Docker Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦♂️ r? `@marcoieni` try-job: x86_64-fuchsia
Take a break from reviews
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
Post-merge analysis result Test differences
(and 10 additional diffs) |
📌 Perf builds for each rolled up PR:
previous master: cb50d4d856 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (ecade53): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.3%, secondary 3.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -1.9%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary -0.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 773.132s -> 774.645s (0.20%) |
Rollup of 9 pull requests Successful merges: - rust-lang#134720 (Display valid crate types in error message for --crate-type flag) - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes) - rust-lang#138353 (remove must_use from <*const T>::expose_provenance) - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`) - rust-lang#138469 (remove comment regarding a removed test directive) - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`) - rust-lang#138485 (Rustc dev guide subtree update) - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker) - rust-lang#138495 (Take a break from reviews) r? `@ghost` `@rustbot` modify labels: rollup
Successful merges:
RUN_CHECK_WITH_PARALLEL_QUERIES
#138452 (RemoveRUN_CHECK_WITH_PARALLEL_QUERIES
)BikeshedGuaranteedNoDrop
#138477 (Deny impls forBikeshedGuaranteedNoDrop
)CI_JOB_DOC_URL
to Docker #138487 (PassCI_JOB_DOC_URL
to Docker)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup