Skip to content

Rollup of 9 pull requests #138506

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 51 commits into from
Mar 14, 2025
Merged

Rollup of 9 pull requests #138506

merged 51 commits into from
Mar 14, 2025

Conversation

fmease
Copy link
Member

@fmease fmease commented Mar 14, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fee1-dead and others added 30 commits February 20, 2025 21:39
Don't suggest explicitly `cfg`-gating `trace!` calls in bootstrap
- There is more than just target and stage
- There is only 3 stages, so don't mention them specially
compiletest directives: ignore-stage0 and only-stage0 do not exist
already mentioned before showing code snippet
Document `fetch.prunetags = true` gotcha during rustc-pull
fmease added 6 commits March 14, 2025 17:26
…lel-queries, r=Mark-Simulacrum,onur-ozkan

Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`

After rust-lang#132282, I'm pretty sure that this is simply useless? It just runs check with an empty config, lol.

CC `@onur-ozkan`

r? `@Noratrieb`
remove comment regarding a removed test directive

Removed in rust-lang#120265
…anteed-no-drop, r=lcnr

Deny impls for `BikeshedGuaranteedNoDrop`

r? lcnr
Rustc dev guide subtree update

r? `@jieyouxu`
…ieni

Pass `CI_JOB_DOC_URL` to Docker

Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦‍♂️

r? `@marcoieni`

try-job: x86_64-fuchsia
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 14, 2025
@fmease
Copy link
Member Author

fmease commented Mar 14, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Mar 14, 2025

📌 Commit 401b325 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@bors
Copy link
Collaborator

bors commented Mar 14, 2025

⌛ Testing commit 401b325 with merge ecade53...

@bors
Copy link
Collaborator

bors commented Mar 14, 2025

☀️ Test successful - checks-actions
Approved by: fmease
Pushing ecade53 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2025
@bors bors merged commit ecade53 into rust-lang:master Mar 14, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 14, 2025
@fmease fmease deleted the rollup-ve4h2eq branch March 14, 2025 20:01
Copy link

Post-merge analysis result

Test differences

  • x86_64-gnu-llvm-18-1
    • library/core/src/marker.rs - marker::Unpin (line 915): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 698): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::as_ptr (line 1527): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset (line 405): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_add (line 1131): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 648): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T;N]::as_ptr (line 1647): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::mask (line 567): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned (line 1418): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-gnu-llvm-18-2
    • library/core/src/marker.rs - marker::PhantomData (line 698): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 667): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref_unchecked (line 315): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::add (line 915): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 648): [missing] -> pass
    • [ui] tests/ui/parser/shebang/shebang-split.rs: [missing] -> pass
    • library/core/src/marker.rs - marker::Unpin (line 915): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::get_unchecked (line 1565): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1174): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-gnu-llvm-19-3
    • library/core/src/marker.rs - marker::CoercePointee (line 1251): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::is_empty (line 1508): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::mask (line 567): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T;N]::as_slice (line 1664): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::sub (line 1021): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T;N]::as_ptr (line 1647): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from_unsigned (line 724): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 681): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_uninit_ref (line 352): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 284): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-gnu-llvm-19-2
    • [ui] tests/ui/parser/shebang/shebang-split.rs: [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 667): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref_unchecked (line 315): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::align_offset (line 1376): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_uninit_ref (line 352): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 681): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_offset (line 510): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::add (line 915): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1251): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned (line 1418): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-mingw-1
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 268): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::as_ptr (line 1527): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 728): [missing] -> pass
    • [ui] tests/ui/parser/shebang/shebang-split.rs: [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned (line 1418): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::len (line 1491): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 698): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_uninit_ref (line 352): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::sub (line 1021): [missing] -> pass
    • (and 58 additional testss)
  • i686-gnu-nopt-1
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned (line 1418): [missing] -> pass
    • [ui] tests/ui/parser/shebang/shebang-split.rs: [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 284): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from_unsigned (line 724): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::sub (line 1021): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 681): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_sub (line 1210): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref_unchecked (line 315): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1127): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1174): [missing] -> pass
    • (and 58 additional testss)
  • aarch64-apple
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_offset (line 510): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::is_empty (line 1508): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 728): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1174): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::get_unchecked (line 1565): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::as_ptr (line 1527): [missing] -> pass
    • library/core/src/marker.rs - marker::Unpin (line 915): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1236): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1251): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-gnu-stable
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::is_empty (line 1508): [missing] -> pass
    • library/core/src/marker.rs - marker::Unpin (line 915): [missing] -> pass
    • library/core/src/marker.rs - marker::PhantomData (line 698): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 648): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::add (line 915): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_sub (line 1210): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::sub (line 1021): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::wrapping_offset (line 510): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref_unchecked (line 315): [missing] -> pass
    • (and 58 additional testss)
  • i686-msvc-1
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from_unsigned (line 752): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T;N]::as_ptr (line 1647): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 648): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T]::is_empty (line 1508): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned_to (line 1450): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 284): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::mask (line 567): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::is_aligned (line 1418): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 268): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::sub (line 1021): [missing] -> pass
    • (and 58 additional testss)
  • x86_64-gnu
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_uninit_ref (line 352): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from_unsigned (line 752): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::align_offset (line 1376): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::as_ref (line 268): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::offset_from (line 662): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*constT::mask (line 567): [missing] -> pass
    • library/core/src/ptr/const_ptr.rs - ptr::const_ptr::*const[T;N]::as_slice (line 1664): [missing] -> pass
    • [ui] tests/ui/parser/shebang/shebang-split.rs: [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1127): [missing] -> pass
    • library/core/src/marker.rs - marker::CoercePointee (line 1174): [missing] -> pass
    • (and 58 additional testss)

(and 10 additional diffs)

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#134720 Display valid crate types in error message for --crate-type… 1586c0bb57d57d8d2ae979b0c8f7362a14ab0b87 (link)
#137619 Provide helpful diagnostics for shebang lookalikes ec824e2daeff91bedd642a9c883634dd9d8641d6 (link)
#138353 remove must_use from <*const T>::expose_provenance b71f679f9defb8473697d0290a001e0f3218d7f4 (link)
#138452 Remove RUN_CHECK_WITH_PARALLEL_QUERIES f6edecaa2eac28d2d42ef30882c02254b745ebf5 (link)
#138469 remove comment regarding a removed test directive 44319feeb026f691c44fdea45288470f3dca58ba (link)
#138477 Deny impls for BikeshedGuaranteedNoDrop fd5e2161272cde124801e083c7ca3bbbb71e7527 (link)
#138485 Rustc dev guide subtree update a0128f2a07db03ddbeacc1787521714358b35c9d (link)
#138487 Pass CI_JOB_DOC_URL to Docker 2e45b525b73f614b1749c835d6e13428800c6a1a (link)
#138495 Take a break from reviews e97fed9fa03067f6a9977dc9ebe66d31ab3d5099 (link)

previous master: cb50d4d856

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ecade53): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Max RSS (memory usage)

Results (primary -1.3%, secondary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.9% [3.9%, 3.9%] 1
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Cycles

Results (primary -1.9%, secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.2%, 3.7%] 11
Improvements ✅
(primary)
-1.9% [-1.9%, -1.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.9% [-1.9%, -1.9%] 1

Binary size

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Bootstrap: 773.132s -> 774.645s (0.20%)
Artifact size: 365.00 MiB -> 364.97 MiB (-0.01%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes)
 - rust-lang#138353 (remove must_use from <*const T>::expose_provenance)
 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)
 - rust-lang#138469 (remove comment regarding a removed test directive)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)
 - rust-lang#138485 (Rustc dev guide subtree update)
 - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker)
 - rust-lang#138495 (Take a break from reviews)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.