replace commit placeholder in vendor status with actual commit #139060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
from
6a46304 to
077a9c2
Compare
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
from
077a9c2 to
562efc9
Compare
onur-ozkan
requested changes
Mar 29, 2025
rustbot
added
S-waiting-on-author
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
from
5ac1e66 to
91d1dd4
Compare
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
It looks good to me now, could you please squash your commits? |
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
from
91d1dd4 to
2ecaac3
Compare
done |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 29, 2025
…it-with-actual-value, r=onur-ozkan replace commit placeholder in vendor status with actual commit closes: rust-lang#120499
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 29, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#137928 (stabilize const_cell) - rust-lang#138431 (Fix `uclibc` LLVM target triples) - rust-lang#138832 (Start using `with_native_path` in `std::sys::fs`) - rust-lang#139060 (replace commit placeholder in vendor status with actual commit) - rust-lang#139081 (std: deduplicate `errno` accesses) - rust-lang#139100 (compiletest: Support matching diagnostics on lines below) - rust-lang#139105 (`BackendRepr::is_signed`: comment why this may panics) - rust-lang#139106 (Mark .pp files as Rust) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
2 times, most recently
from
cfb06e5 to
cdfed12
Compare
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 1, 2025
…it-with-actual-value, r=onur-ozkan replace commit placeholder in vendor status with actual commit closes: rust-lang#120499
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 1, 2025
…it-with-actual-value, r=onur-ozkan replace commit placeholder in vendor status with actual commit closes: rust-lang#120499
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
Rollup of 12 pull requests Successful merges: - rust-lang#110406 (rustdoc-json: Add test for #[automatically_derived] attribute) - rust-lang#137738 (Make slice iterator constructors unstably const) - rust-lang#138492 (remove `feature(inline_const_pat)`) - rust-lang#138928 (Fix UWP reparse point check) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139002 (Add release notes for 1.86.0) - rust-lang#139022 (increment depth of nested obligations) - rust-lang#139060 (replace commit placeholder in vendor status with actual commit) - rust-lang#139102 (coverage: Avoid splitting spans during span extraction/refinement) - rust-lang#139129 (Add tests for slice bounds check optimization) - rust-lang#139188 (PassWrapper: adapt for llvm/llvm-project@94122d58fc77079a291a3d008914…) - rust-lang#139193 (Feed HIR for by-move coroutine body def, since the inliner tries to read its attrs) r? `@ghost` `@rustbot` modify labels: rollup
|
Failed in rollup: #139204 (comment) |
bors
added
S-waiting-on-author
Shourya742
force-pushed
the
2025-03-28-replace-commit-with-actual-value
branch
from
4564280 to
2dc650b
Compare
|
@rustbot review, |
rustbot
added
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
…-with-actual-value, r=<try> replace commit placeholder in vendor status with actual commit closes: rust-lang#120499 try-job: dist-x86_64-illumos
|
☀️ Try build successful - checks-actions |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
Rollup of 14 pull requests Successful merges: - rust-lang#135295 (Check empty SIMD vector in inline asm) - rust-lang#138003 (Add the new `amx` target features and the `movrs` target feature) - rust-lang#138823 (rustc_target: RISC-V: add base `I`-related important extensions) - rust-lang#138913 (Remove even more instances of `@ts-expect-error` from search.js) - rust-lang#138941 (Do not mix normalized and unnormalized caller bounds when constructing param-env for `receiver_is_dispatchable`) - rust-lang#139060 (replace commit placeholder in vendor status with actual commit) - rust-lang#139102 (coverage: Avoid splitting spans during span extraction/refinement) - rust-lang#139191 (small opaque type/borrowck cleanup) - rust-lang#139200 (Skip suggest impl or dyn when poly trait is not a real trait) - rust-lang#139208 (fix dead link netbsd.md) - rust-lang#139210 (chore: remove redundant backtick) - rust-lang#139212 (Update mdbook to 0.4.48) - rust-lang#139214 (Tell rustfmt to use the 2024 edition in ./x.py fmt) - rust-lang#139225 (move autodiff from EnzymeAD/Enzyme to our rust-lang/Enzyme soft-fork) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
Rollup merge of rust-lang#139060 - Shourya742:2025-03-28-replace-commit-with-actual-value, r=onur-ozkan replace commit placeholder in vendor status with actual commit closes: rust-lang#120499 try-job: dist-x86_64-illumos
|
This doesn't seem to work in CI: The git version on CI should be |
|
I haven't found anything in the git changelog that would suggest that it was removed though. @Shourya742 Could you please try to take a look at how to fix this with the git that we use on CI? |
Where did this fail? This isn't a game changer improvement so feel free to revert it if it's being a blocker or something. |
|
It fails e.g. in dist-x86_64-linux. The error is ignores, so it doesn't block CI. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #120499
try-job: dist-x86_64-illumos