-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Apply Recovery::Forbidden
when reparsing pasted macro fragments.
#139341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
I accidentally added this in rust-lang#138740.
This is the exact spot where the problem was occurring: rust/compiler/rustc_parse/src/parser/pat.rs Lines 794 to 804 in 00095b3
The |
This comment has been minimized.
This comment has been minimized.
Fixes rust-lang#137874. Removes `tests/crashes/137874.rs`; the new test is simpler (defines its own macro) but tests the same thing. The changes to the output of `tests/ui/associated-consts/issue-93835.rs` partly undo the changes seen when `NtTy` was removed in rust-lang#133436, which is good.
This PR changes a file inside |
@bors r+ |
…nkov Apply `Recovery::Forbidden` when reparsing pasted macro fragments. Fixes rust-lang#137874. The changes to the output of `tests/ui/associated-consts/issue-93835.rs` partly undo the changes seen when `NtTy` was removed in rust-lang#133436, which is good. r? `@petrochenkov`
Rollup of 11 pull requests Successful merges: - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137880 (Autodiff batching) - rust-lang#137897 (fix pthread-based tls on apple targets) - rust-lang#138024 (Allow optimizing out `panic_bounds_check` in Unicode checks.) - rust-lang#138546 (Add integer to string formatting tests) - rust-lang#138826 (StableMIR: Add `associated_items`.) - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names) - rust-lang#139274 (Rustdoc: typecheck settings.js) - rust-lang#139285 (use lower case to match other error messages) - rust-lang#139341 (Apply `Recovery::Forbidden` when reparsing pasted macro fragments.) - rust-lang#139389 (make `Arguments::as_statically_known_str` doc(hidden)) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#139341 - nnethercote:fix-137874, r=petrochenkov Apply `Recovery::Forbidden` when reparsing pasted macro fragments. Fixes rust-lang#137874. The changes to the output of `tests/ui/associated-consts/issue-93835.rs` partly undo the changes seen when `NtTy` was removed in rust-lang#133436, which is good. r? ``@petrochenkov``
Beta-backporting rust-lang#140228 has the same effect on this test as rust-lang#139341 already had on master.
Fixes #137874.
The changes to the output of
tests/ui/associated-consts/issue-93835.rs
partly undo the changes seen when
NtTy
was removed in #133436, whichis good.
r? @petrochenkov