Skip to content

make Arguments::as_statically_known_str doc(hidden) #139389

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

mejrs
Copy link
Contributor

@mejrs mejrs commented Apr 4, 2025

Fixes as_statically_known_str being visible (Rendered)

This snuck in with #138650, cc @thaliaarchi

This is also visible in the beta docs.

@rustbot label +beta-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 4, 2025
@thaliaarchi
Copy link
Contributor

Thanks!

@workingjubilee
Copy link
Member

Oh whoops.

@bors r+ rollup

I don't think the beta backport matters much because it's still unstable, but if people want then it's also basically harmless.

@bors
Copy link
Collaborator

bors commented Apr 4, 2025

📌 Commit cfcc47e has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang#136457 (Expose algebraic floating point intrinsics)
 - rust-lang#137880 (Autodiff batching)
 - rust-lang#137897 (fix pthread-based tls on apple targets)
 - rust-lang#138024 (Allow optimizing out `panic_bounds_check` in Unicode checks.)
 - rust-lang#138546 (Add integer to string formatting tests)
 - rust-lang#138826 (StableMIR: Add `associated_items`.)
 - rust-lang#138950 (replace extra_filename with strict version hash in metrics file names)
 - rust-lang#139274 (Rustdoc: typecheck settings.js)
 - rust-lang#139285 (use lower case to match other error messages)
 - rust-lang#139341 (Apply `Recovery::Forbidden` when reparsing pasted macro fragments.)
 - rust-lang#139389 (make `Arguments::as_statically_known_str` doc(hidden))

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e31ce50 into rust-lang:master Apr 5, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2025
Rollup merge of rust-lang#139389 - mejrs:hidden, r=workingjubilee

make `Arguments::as_statically_known_str` doc(hidden)

Fixes `as_statically_known_str` being [visible](https://doc.rust-lang.org/nightly/std/fmt/struct.Arguments.html#method.as_statically_known_str) ([Rendered](https://github.com/user-attachments/assets/45482d9f-2ec5-4610-be9c-b231bd2850c6))

This snuck in with rust-lang#138650, cc `@thaliaarchi`

This is also visible in the beta docs.

`@rustbot` label +beta-nominated
@rustbot rustbot added this to the 1.88.0 milestone Apr 5, 2025
@Amanieu Amanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 9, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 10, 2025
make `Arguments::as_statically_known_str` doc(hidden)

Fixes `as_statically_known_str` being [visible](https://doc.rust-lang.org/nightly/std/fmt/struct.Arguments.html#method.as_statically_known_str) ([Rendered](https://github.com/user-attachments/assets/45482d9f-2ec5-4610-be9c-b231bd2850c6))

This snuck in with rust-lang#138650, cc `@thaliaarchi`

This is also visible in the beta docs.

`@rustbot` label +beta-nominated
@cuviper cuviper mentioned this pull request Apr 17, 2025
@cuviper cuviper modified the milestones: 1.88.0, 1.87.0 Apr 17, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2025
[beta] backports

- Fix 2024 edition doctest panic output rust-lang#139328
- make `Arguments::as_statically_known_str` doc(hidden) rust-lang#139389
- Revert "Deduplicate template parameter creation" rust-lang#139878
- sync::mpsc: prevent double free on `Drop` rust-lang#139553

r? cuviper
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants