Skip to content

[beta] backports #139988

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 19, 2025
Merged

[beta] backports #139988

merged 7 commits into from
Apr 19, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 17, 2025 •
edited
Loading

r? cuviper

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 17, 2025
@petrosagg @cuviper
sync::mpsc: add miri reproducer of double free
e71ad4a 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
(cherry picked from commit 9eb6a54)
@petrosagg @cuviper
sync::mpsc: prevent double free on Drop
f31cf5c 
This PR is fixing a regression introduced by rust-lang#121646 that can lead to a
double free when dropping the channel.

The details of the bug can be found in the corresponding crossbeam PR
crossbeam-rs/crossbeam#1187

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
(cherry picked from commit b9e2ac5)
@cuviper
Copy link
Member Author

cuviper commented Apr 18, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Apr 18, 2025

📌 Commit f31cf5c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2025
@bors
Copy link
Collaborator

bors commented Apr 19, 2025

⌛ Testing commit f31cf5c with merge 386abeb...

@bors
Copy link
Collaborator

bors commented Apr 19, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 386abeb to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 19, 2025
@bors bors merged commit 386abeb into rust-lang:beta Apr 19, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Apr 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @bors @rustbot @GuillaumeGomez @mejrs @petrochenkov @petrosagg