build_helper: temporarily swallow remove dir failure #140119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to very high failure rate of `tests/mir-opt/strip_debuginfo.rs` for unknown reasons, cf. <rust-lang#134351>.
rustbot
added
S-waiting-on-review
|
|
jieyouxu
added
S-waiting-on-author
|
I'll close this but keep the branch, in case this becomes necessary. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to very high failure rate of
tests/mir-opt/strip_debuginfo.rsfor unknown reasons, cf. #134351. This restores the previous silently swallow remove dir behavior prior to #139870, but would mask genuine bugs.Only merge this PR if
tests/mir-opt/strip_debuginfo.rsfailure rates become unbearably high.Backlink to tracking issue: #134351
r? @ChrisDenton