add retries to remove and create dir all #139870

Shourya742 · 2025-04-15T14:05:20Z

closes: #139230

r? @jieyouxu

rustbot · 2025-04-15T14:05:27Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

src/tools/compiletest/src/runtest.rs

src/build_helper/src/fs/mod.rs

rustbot · 2025-04-16T05:11:51Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This PR modifies run-make tests.

cc @jieyouxu

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/opt-dist

cc @Kobzol

The Miri subtree was changed

cc @rust-lang/miri

Shourya742 · 2025-04-16T05:23:35Z

@rustbot review

src/build_helper/src/fs/mod.rs

rustbot · 2025-04-16T06:59:10Z

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @vakaras

src/tools/compiletest/src/runtest.rs

jieyouxu

Thanks, a few more nits

src/build_helper/src/fs/mod.rs

src/tools/compiletest/src/runtest.rs

jieyouxu · 2025-04-16T14:28:01Z

@rustbot author

rustbot · 2025-04-16T14:28:06Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

…_create_dir_all

Shourya742 · 2025-04-16T16:24:35Z

@rustbot review

jieyouxu

Thanks

jieyouxu · 2025-04-17T13:28:08Z

@bors r+ rollup

bors · 2025-04-17T13:28:11Z

📌 Commit d4eab8a has been approved by jieyouxu

It is now in the queue for this repository.

…to-remove_and_create_dir_all, r=jieyouxu add retries to remove and create dir all closes: rust-lang#139230 r? `@jieyouxu`

…to-remove_and_create_dir_all, r=jieyouxu add retries to remove and create dir all closes: rust-lang#139230 r? ``@jieyouxu``

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#139774 (Fix replacing supertrait aliases in `ReplaceProjectionWith`) - rust-lang#139850 (Hide unstable print kinds within emit_unknown_print_request_help in stable channel) - rust-lang#139870 (add retries to remove and create dir all) - rust-lang#139902 (do not emit `OpaqueCast` projections with `-Znext-solver`) - rust-lang#139931 (bootstrap: enable zlib for LLVM for Windows GNU) - rust-lang#139935 (Upgrade to `rustc-rayon-core` 0.5.1) - rust-lang#139943 (rustdoc: Support inlined cross-crate re-exported trait aliases) - rust-lang#139961 (Two `rustc_const_eval` cleanups) - rust-lang#139962 (opt-dist: add a flag for running tests) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139870 - Shourya742:2025-04-15-add-retries-to-remove_and_create_dir_all, r=jieyouxu add retries to remove and create dir all closes: rust-lang#139230 r? ```@jieyouxu```

rustbot assigned jieyouxu Apr 15, 2025

jieyouxu requested changes Apr 15, 2025

View reviewed changes

src/tools/compiletest/src/runtest.rs Outdated Show resolved Hide resolved

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

bjorn3 reviewed Apr 15, 2025

View reviewed changes

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025

bjorn3 reviewed Apr 15, 2025

View reviewed changes

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 09b2162 to 74ab918 Compare April 16, 2025 05:11

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 16, 2025

Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 74ab918 to bd59c94 Compare April 16, 2025 05:20

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025

RalfJung reviewed Apr 16, 2025

View reviewed changes

src/build_helper/src/fs/mod.rs Show resolved Hide resolved

src/build_helper/src/fs/mod.rs Show resolved Hide resolved

Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from bd59c94 to 37da1f0 Compare April 16, 2025 06:59

Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 37da1f0 to b5952db Compare April 16, 2025 06:59

This comment was marked as off-topic.

# to view

fbstj reviewed Apr 16, 2025

View reviewed changes

src/tools/compiletest/src/runtest.rs Show resolved Hide resolved

jieyouxu reviewed Apr 16, 2025

View reviewed changes

src/build_helper/src/fs/mod.rs Show resolved Hide resolved

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

src/build_helper/src/fs/mod.rs Outdated Show resolved Hide resolved

src/tools/compiletest/src/runtest.rs Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2025

jieyouxu removed WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) A-run-make Area: port run-make Makefiles to rmake.rs labels Apr 16, 2025

Shourya742 added 3 commits April 16, 2025 21:53

add retry support to recursive_remove

96984c0

add remove_and_create_dir_all in build_helper

003d633

remove old remove_and_create_dir_all and use build_helpers remove_and…

d4eab8a

…_create_dir_all

Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from b5952db to d4eab8a Compare April 16, 2025 16:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025

jieyouxu approved these changes Apr 17, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2025

matthiaskrgr mentioned this pull request Apr 17, 2025

Rollup of 10 pull requests #139973

Closed

This was referenced Apr 17, 2025

Rollup of 9 pull requests #139975

Closed

Rollup of 9 pull requests #139979

Merged

bors merged commit cecc7a4 into rust-lang:master Apr 17, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 17, 2025

This was referenced Apr 21, 2025

ci: spurious failure tests\mir-opt\strip_debuginfo.rs Cannot create a file when that file already exists.` #134351

Open

build_helper: temporarily swallow remove dir failure #140119

Closed

add retries to remove and create dir all #139870

add retries to remove and create dir all #139870

Uh oh!

Conversation

Shourya742 commented Apr 15, 2025

Uh oh!

rustbot commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 16, 2025

Uh oh!

Shourya742 commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 16, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Apr 16, 2025

Uh oh!

rustbot commented Apr 16, 2025

Uh oh!

Shourya742 commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Apr 17, 2025

Uh oh!

bors commented Apr 17, 2025

Uh oh!

Uh oh!

Uh oh!

Shourya742 commented Apr 16, 2025 •

edited

Loading