Skip to content

std: explain prefer TryInto over TryFrom when specifying traits bounds on generic function #140791

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented May 8, 2025

Fixes #140761

This PR keeps the explanations of Into and From consistent and adds explanations for TryInto and TryFrom.

r? libs

xizheyin added 2 commits May 8, 2025 18:09
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
…ounds on generic function

Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 8, 2025
@ibraheemdev
Copy link
Member

Thanks. @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 16, 2025

📌 Commit 4101d90 has been approved by ibraheemdev

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#140791 (std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function)
 - rust-lang#140834 (move (or remove) some impl Trait tests)
 - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at)
 - rust-lang#140984 (fix doc for UnixStream)
 - rust-lang#140997 (Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features`)
 - rust-lang#141003 (Improve ternary operator recovery)
 - rust-lang#141009 (Migrate to modern datetime API)
 - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows)
 - rust-lang#141026 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
hkBst added a commit to hkBst/rust that referenced this pull request May 16, 2025
std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function

Fixes rust-lang#140761

This PR keeps the explanations of `Into` and `From` consistent and adds explanations for `TryInto` and `TryFrom`.

r? libs
@bors bors merged commit 315296b into rust-lang:master May 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
Rollup merge of rust-lang#140791 - xizheyin:issue-140761, r=ibraheemdev

std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function

Fixes rust-lang#140761

This PR keeps the explanations of `Into` and `From` consistent and adds explanations for `TryInto` and `TryFrom`.

r? libs
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 21, 2025
std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function

Fixes rust-lang#140761

This PR keeps the explanations of `Into` and `From` consistent and adds explanations for `TryInto` and `TryFrom`.

r? libs
@xizheyin xizheyin deleted the issue-140761 branch June 1, 2025 06:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TryFrom and TryInto docs don't say that TryInto should be preferred in bounds.
4 participants