Skip to content

Implement methods to set STARTUPINFO flags for Command API on Windows #141013

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Implement methods to set STARTUPINFO flags for Command API on Windows #141013

merged 1 commit into from
May 16, 2025

Conversation

federico-terzi
Copy link
Contributor

Implements #141010

@rustbot
Copy link
Collaborator

rustbot commented May 14, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 14, 2025
This was referenced May 14, 2025
Open
Closed
@joboet
Copy link
Member

joboet commented May 15, 2025

Looks fine!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 15, 2025

📌 Commit e0b6363 has been approved by joboet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 15, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2025
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 15, 2025
@compiler-errors
Rollup merge of rust-lang#141013 - federico-terzi:feat/command_startu…
996cb38 
…pinfo_windows, r=joboet

Implement methods to set STARTUPINFO flags for Command API on Windows

Implements rust-lang#141010
@compiler-errors compiler-errors mentioned this pull request May 15, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2025
@bors
Auto merge of rust-lang#141041 - compiler-errors:rollup-tz4bpbf, r=co…
622f000 
…mpiler-errors

Rollup of 14 pull requests

Successful merges:

 - rust-lang#139749 (docs(library/core/src/pin): fix typo "necessarily" -> "necessary")
 - rust-lang#140130 (Add LLDB providers for BTreeMap and BTreeSet)
 - rust-lang#140685 (Simplify `Vec::as_non_null` implementation and make it `const`)
 - rust-lang#140712 (normalization: avoid incompletely constraining GAT args)
 - rust-lang#140768 (Improve `dangerous_implicit_aurorefs` diagnostic output)
 - rust-lang#140834 (move (or remove) some impl Trait tests)
 - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at)
 - rust-lang#140947 (Flush errors before deep normalize in `dropck_outlives`)
 - rust-lang#140966 (Remove #![feature(let_chains)] from library and src/librustdoc)
 - rust-lang#140977 ([win] Use a dash instead of slash for linker to avoid breaking lld)
 - rust-lang#140990 (VxWorks: updates from recent libc versions)
 - rust-lang#141003 (Improve ternary operator recovery)
 - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows)
 - rust-lang#141026 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request May 16, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@bors
Auto merge of rust-lang#141066 - matthiaskrgr:rollup-e7tyrj5, r=matth…
c79bbfa 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#140791 (std: explain prefer `TryInto` over `TryFrom` when specifying traits bounds on generic function)
 - rust-lang#140834 (move (or remove) some impl Trait tests)
 - rust-lang#140910 (Remove `stable` attribute from wasi fs (read_exact|write_all)_at)
 - rust-lang#140984 (fix doc for UnixStream)
 - rust-lang#140997 (Add negative test coverage for `-Clink-self-contained` and `-Zlinker-features`)
 - rust-lang#141003 (Improve ternary operator recovery)
 - rust-lang#141009 (Migrate to modern datetime API)
 - rust-lang#141013 (Implement methods to set STARTUPINFO flags for Command API on Windows)
 - rust-lang#141026 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
hkBst added a commit to hkBst/rust that referenced this pull request May 16, 2025
@hkBst
Rollup merge of rust-lang#141013 - federico-terzi:feat/command_startu…
3da241f 
…pinfo_windows, r=joboet

Implement methods to set STARTUPINFO flags for Command API on Windows

Implements rust-lang#141010
@hkBst hkBst mentioned this pull request May 16, 2025
Closed
@bors bors merged commit 03912f4 into rust-lang:master May 16, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 16, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2025
@rust-timer
Unrolled build for rust-lang#141013
58ea768 
Rollup merge of rust-lang#141013 - federico-terzi:feat/command_startupinfo_windows, r=joboet

Implement methods to set STARTUPINFO flags for Command API on Windows

Implements rust-lang#141010
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 21, 2025
@matthiaskrgr
Rollup merge of rust-lang#141013 - federico-terzi:feat/command_startu…
4034981 
…pinfo_windows, r=joboet

Implement methods to set STARTUPINFO flags for Command API on Windows

Implements rust-lang#141010
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@joboet joboet

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
4 participants
@federico-terzi @rustbot @joboet @bors