Rollup of 7 pull requests

[GuillaumeGomez]

Successful merges:

• tests/ui: A New Order [13/N] #142429 (tests/ui: A New Order [13/N])
• Use let chains in the new solver #143066 (Use let chains in the new solver)
• inherit #[align] from trait method prototypes #143156 (inherit #[align] from trait method prototypes)
• fix typos and improve clarity in documentation #143176 (fix typos and improve clarity in documentation)
• Add my work email to mailmap #143187 (Add my work email to mailmap)
• fix bitcast of single-element SIMD vectors #143194 (fix bitcast of single-element SIMD vectors)
• Re-disable tests/run-make/short-ice on Windows MSVC again #143199 (Re-disable tests/run-make/short-ice on Windows MSVC again)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[GuillaumeGomez]

@bors r+ p=5 rollup=never

[bors]

📌 Commit e28298e has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit e28298e with merge 012c38d...

[rust-log-analyzer]

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [codegen] tests/codegen/transmute-scalar.rs stdout ----

error: compilation failed!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/codegen/transmute-scalar.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=wasm32-wasip1" "--check-cfg" "cfg(test,FALSE)" "-O" "-Cdebug-assertions=no" "--emit" "llvm-ir" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/transmute-scalar/transmute-scalar.ll" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-C" "opt-level=0" "-C" "no-prepopulate-passes"
stdout: none
--- stderr -------------------------------
warning: type `S` is more private than the item `single_element_simd_to_scalar`
##[warning]   --> /checkout/tests/codegen/transmute-scalar.rs:113:1
    |
113 | pub extern "C" fn single_element_simd_to_scalar(b: S) -> i64 {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `single_element_simd_to_scalar` is reachable at visibility `pub`
    |
note: but type `S` is only usable at visibility `pub(crate)`
   --> /checkout/tests/codegen/transmute-scalar.rs:107:1
    |
107 | struct S([i64; 1]);
    | ^^^^^^^^
    = note: `#[warn(private_interfaces)]` on by default

warning: type `S` is more private than the item `scalar_to_single_element_simd`
##[warning]   --> /checkout/tests/codegen/transmute-scalar.rs:121:1
    |
121 | pub extern "C" fn scalar_to_single_element_simd(b: i64) -> S {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `scalar_to_single_element_simd` is reachable at visibility `pub`
    |
note: but type `S` is only usable at visibility `pub(crate)`
   --> /checkout/tests/codegen/transmute-scalar.rs:107:1
    |
107 | struct S([i64; 1]);
    | ^^^^^^^^

---
   |              -------------------^^^
   |              |
   |              help: replace this with: `u8::from`

warning: `extern` fn uses type `S`, which is not FFI-safe
##[warning]   --> /checkout/tests/codegen/transmute-scalar.rs:113:52
    |
113 | pub extern "C" fn single_element_simd_to_scalar(b: S) -> i64 {
    |                                                    ^ not FFI-safe
    |
    = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
    = note: this struct has unspecified layout
note: the type is defined here
   --> /checkout/tests/codegen/transmute-scalar.rs:107:1
    |
107 | struct S([i64; 1]);
    | ^^^^^^^^
    = note: `#[warn(improper_ctypes_definitions)]` on by default

warning: `extern` fn uses type `S`, which is not FFI-safe
##[warning]   --> /checkout/tests/codegen/transmute-scalar.rs:121:60
    |
121 | pub extern "C" fn scalar_to_single_element_simd(b: i64) -> S {
    |                                                            ^ not FFI-safe
    |
    = help: consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct
    = note: this struct has unspecified layout
note: the type is defined here
   --> /checkout/tests/codegen/transmute-scalar.rs:107:1
    |
107 | struct S([i64; 1]);
    | ^^^^^^^^

error: this function definition uses SIMD vector type `S` which (with the chosen ABI) requires the `simd128` target feature, which is not enabled
##[error]   --> /checkout/tests/codegen/transmute-scalar.rs:113:1
    |
113 | pub extern "C" fn single_element_simd_to_scalar(b: S) -> i64 {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function defined here
    |
    = help: consider enabling it globally (`-C target-feature=+simd128`) or locally (`#[target_feature(enable="simd128")]`)

error: this function definition uses SIMD vector type `S` which (with the chosen ABI) requires the `simd128` target feature, which is not enabled
##[error]   --> /checkout/tests/codegen/transmute-scalar.rs:121:1
    |
121 | pub extern "C" fn scalar_to_single_element_simd(b: i64) -> S {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function defined here
    |
    = help: consider enabling it globally (`-C target-feature=+simd128`) or locally (`#[target_feature(enable="simd128")]`)

error: aborting due to 2 previous errors; 6 warnings emitted
------------------------------------------

[bors]

💔 Test failed - checks-actions