Skip to content

Make casts follow the new RFC401 #24333

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 9 commits into from
May 19, 2015
Merged

Make casts follow the new RFC401 #24333

merged 9 commits into from
May 19, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Apr 11, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor Author

arielb1 commented Apr 11, 2015

ping @nrc, not r? yet

@nrc nrc unassigned eddyb Apr 11, 2015
@alexcrichton
Copy link
Member

r? @nrc

(just making sure all PRs have an assignee)

@arielb1
Copy link
Contributor Author

arielb1 commented Apr 20, 2015

This is based on top of #24615 so I can test it faster. I will rebase before r? anyway.

@bors
Copy link
Collaborator

bors commented May 2, 2015

☔ The latest upstream changes (presumably #25038) made this pull request unmergeable. Please resolve the merge conflicts.

@bluss
Copy link
Member

bluss commented May 2, 2015

I'm sorry for the disruption, I didn't know this was in the works. My patch was small, so it should be simple.

@arielb1 arielb1 force-pushed the implement-rfc401 branch from 1529183 to 379cef8 Compare May 4, 2015 20:53
@arielb1
Copy link
Contributor Author

arielb1 commented May 5, 2015

@bluss

I'm throwing the code out anyway. Shouldn't matter

@arielb1 arielb1 force-pushed the implement-rfc401 branch from 379cef8 to 4f965c8 Compare May 5, 2015 16:40
@arielb1 arielb1 changed the title WIP: Make casts follow the new RFC401 Make casts follow the new RFC401 May 5, 2015
@arielb1 arielb1 force-pushed the implement-rfc401 branch 2 times, most recently from 13c4999 to c158bb4 Compare May 5, 2015 18:50
@arielb1
Copy link
Contributor Author

arielb1 commented May 5, 2015

r? @nrc

Wow there were so many bugs here.

@arielb1 arielb1 mentioned this pull request May 6, 2015
Closed
@arielb1 arielb1 force-pushed the implement-rfc401 branch from 7ac13bd to 3c7bf20 Compare May 12, 2015 23:03
@bors
Copy link
Collaborator

bors commented May 13, 2015

☔ The latest upstream changes (presumably #24619) made this pull request unmergeable. Please resolve the merge conflicts.

@arielb1 arielb1 force-pushed the implement-rfc401 branch 3 times, most recently from 8a146e4 to 74e2bc5 Compare May 13, 2015 22:40
nrc
nrc reviewed May 13, 2015
View reviewed changes
src/test/compile-fail/cast-rfc0401.rs

fn illegal_cast_2<U:?Sized>(u: *const U) -> *const str
{
u as *const str //~ ERROR vtable kinds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test for *const str as *const U (or something similar)?

@bors
Copy link
Collaborator

bors commented May 15, 2015

💔 Test failed - auto-mac-64-nopt-t

@arielb1 arielb1 force-pushed the implement-rfc401 branch from 5d1b027 to e2f5f1b Compare May 15, 2015 09:09
@Manishearth
Copy link
Member

@bors: r=nrc p=1 force

@bors
Copy link
Collaborator

bors commented May 15, 2015

📌 Commit e2f5f1b has been approved by nrc

@bors
Copy link
Collaborator

bors commented May 15, 2015

⌛ Testing commit e2f5f1b with merge 32d0328...

@bors
Copy link
Collaborator

bors commented May 15, 2015

💔 Test failed - auto-win-32-nopt-t

This was referenced May 15, 2015
Merged
Closed
Ariel Ben-Yehuda and others added 8 commits May 19, 2015 17:42
@arielb1
Expose enum discriminant signedness
a172f40
@arielb1
Overhaul cast semantics and make them follow RFC401
83acebc 
This should hopefully fix all cast-related ICEs once and for all.

I managed to make diagnostics hate me and give me spurious "decoder error"
 - removing $build/tmp/extended-errors seems to fix it.
@arielb1
Fix test fallout, and add some rather comprehensive tests.
9ee2335
@arielb1
fix conflicts
d9b9f4e
@arielb1
remove todo
de4b0e9
@arielb1
Address review commets
32fe2e3 
I think I didn't run tests properly - my second call to
select_all_obligations_or_error has made 3 tests fail. However, this is
just an error message change - integer fallback never worked with casts.
@arielb1
Make float -> int casts actually work
27d2bd1
@arielb1
Fix translation of semi-constant if-statements
3afd760 
Thanks @dotdash
@arielb1 arielb1 force-pushed the implement-rfc401 branch from e2f5f1b to e7e1fd2 Compare May 19, 2015 19:54
@arielb1
Copy link
Contributor Author

arielb1 commented May 19, 2015

Fixed test failure

@arielb1
Copy link
Contributor Author

arielb1 commented May 19, 2015

Thanks @dotdash

@dotdash
Copy link
Contributor

dotdash commented May 19, 2015

@bors r=nrc

@bors
Copy link
Collaborator

bors commented May 19, 2015

📌 Commit e7e1fd2 has been approved by nrc

bors added a commit that referenced this pull request May 19, 2015
@bors
Auto merge of #24333 - arielb1:implement-rfc401, r=nrc
c322dbb
@bors
Copy link
Collaborator

bors commented May 19, 2015

⌛ Testing commit e7e1fd2 with merge c322dbb...

@bors
Copy link
Collaborator

bors commented May 19, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit e7e1fd2 into rust-lang:master May 19, 2015
This was referenced May 19, 2015
Merged
Merged
@mitaa mitaa mentioned this pull request Jun 19, 2015
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arielb1 @rust-highfive @alexcrichton @bors @bluss @nrc @Manishearth @dotdash @eddyb