Call skolemize_late_bound_regions only after fast rejection #24615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skolemize_late_bound_regions essentially copies the entire type (most of the times it shouldn't, but it does), and match_impl runs millions of times. Times compiling rustc, tested with $ make -j4 rustc-stage1 $ ( time RUSTFLAGS=-Z time-passes make -j4 rustc-stage2 ) # need LLVM time for calibration Before: real 21m44.960s user 29m38.812s sys 0m14.944s After: real 19m31.445s user 26m47.260s sys 0m14.952s Making this is a 10% performance improvement. LLVM passes took 867 seconds before, 862 seconds after.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
(not super familiar with this code) |
|
also cc @pnkfelix |
bors
added a commit
that referenced
this pull request
Apr 23, 2015
skolemize_late_bound_regions essentially copies the entire type (most of the times it shouldn't, but it does), and match_impl runs millions of times. Times compiling rustc, tested with $ make -j4 rustc-stage1 $ ( time RUSTFLAGS=-Z time-passes make -j4 rustc-stage2 ) # need LLVM time for calibration Before: real 21m44.960s user 29m38.812s sys 0m14.944s After: real 19m31.445s user 26m47.260s sys 0m14.952s Making this is a 10% performance improvement. LLVM passes took 867 seconds before, 862 seconds after.
|
Sweet wins! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skolemize_late_bound_regions essentially copies the entire type (most of the times it shouldn't, but it does), and match_impl runs millions of times.
Times compiling rustc, tested with
$ make -j4 rustc-stage1
$ ( time RUSTFLAGS=-Z time-passes make -j4 rustc-stage2 ) # need LLVM time for calibration
Before:
real 21m44.960s
user 29m38.812s
sys 0m14.944s
After:
real 19m31.445s
user 26m47.260s
sys 0m14.952s
Making this is a 10% performance improvement.
LLVM passes took 867 seconds before, 862 seconds after.