typeck: if a private field exists, also check for a public method #33342

birkenfeld · 2016-05-02T12:55:39Z

For example, Vec::len is both a field and a method, and usually encountering vec.len just means that the parens were forgotten.

Fixes: #26472

NOTE: I added the parameter allow_private to method::exists since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to false as well, but I wanted to preserve compatibility for this case.

rust-highfive · 2016-05-02T12:55:52Z

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

arielb1 · 2016-05-02T13:35:27Z

@bors r+ fcebf52

@bors rollup

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

Nashenas88 · 2016-05-03T12:11:11Z

I believe there was some discussion in internals.rust-lang.org about making these kinds of messages help instead of note. I'll add a link if I can find it.

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

steveklabnik · 2016-05-05T21:14:27Z

@bors: r-

another commit got added here, I don't know why bors still thought it was reviewed

steveklabnik · 2016-05-05T21:16:45Z

It also appears to have failed the rollup http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/4104/steps/compile/logs/stdio

birkenfeld · 2016-05-06T03:45:17Z

@steveklabnik I didn't add another commit, I rebased and fixed up the existing after seeing that the rollup failed.

jseyfried · 2016-05-10T07:42:42Z

src/librustc_typeck/check/mod.rs

+            // Also check if an accessible method exists, which is often what is meant.
+            if method::exists(fcx, field.span, field.node, expr_t, expr.id, false) {
+                err.note(&format!("a method called `{}` also exists, \
+                                   maybe a `()` to call it is missing?",


nit: a method named {} or just `a method `{}

Also, I would prefer perhaps you wish to call it as in this error message (instead of maybe a () to call it is missing?).

jseyfried · 2016-05-10T07:44:12Z

r=me with the nit addressed

birkenfeld · 2016-05-10T08:27:18Z

r? @jseyfried

jseyfried · 2016-05-10T08:31:52Z

Thanks!
@bors r+

bors · 2016-05-10T08:31:54Z

📌 Commit 84034d4 has been approved by jseyfried

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

bors · 2016-05-11T10:00:52Z

☔ The latest upstream changes (presumably #33425) made this pull request unmergeable. Please resolve the merge conflicts.

Rollup of 9 pull requests - Successful merges: #33129, #33260, #33345, #33386, #33522, #33524, #33528, #33539, #33542 - Failed merges: #33342, #33475, #33517

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

Rollup of 23 pull requests - Successful merges: #33282, #33342, #33393, #33450, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33555, #33560, #33563, #33565, #33566, #33572, #33580, #33590, #33596 - Failed merges: #33578

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

Rollup of 15 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33590, #33591, #33598, #33603, #33604, #33605 - Failed merges: #33578

typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.

Rollup of 14 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33590, #33591, #33598 - Failed merges: #33578

Rollup of 27 pull requests - Successful merges: #33342, #33393, #33415, #33475, #33517, #33533, #33534, #33565, #33580, #33584, #33585, #33588, #33590, #33591, #33593, #33598, #33600, #33602, #33603, #33604, #33605, #33607, #33612, #33620, #33633, #33634, #33635 - Failed merges: #33578

rust-highfive assigned Aatch May 2, 2016

steveklabnik mentioned this pull request May 2, 2016

Rollup of 7 pull requests #33349

Closed

steveklabnik mentioned this pull request May 5, 2016

Rollup of 14 pull requests #33440

Closed

birkenfeld force-pushed the issue-26472 branch from fcebf52 to fa4e401 Compare May 5, 2016 20:26

jseyfried reviewed May 10, 2016
View reviewed changes

birkenfeld force-pushed the issue-26472 branch from fa4e401 to 84034d4 Compare May 10, 2016 08:27

steveklabnik mentioned this pull request May 10, 2016

Rollup of 9 pull requests #33548

Closed

steveklabnik mentioned this pull request May 10, 2016

Rollup of 8 pull requests #33551

Closed

steveklabnik mentioned this pull request May 11, 2016

Rollup of 9 pull requests #33556

Merged

bors added a commit that referenced this pull request May 11, 2016

Auto merge of #33556 - steveklabnik:rollup, r=steveklabnik

e37f859

Rollup of 9 pull requests - Successful merges: #33129, #33260, #33345, #33386, #33522, #33524, #33528, #33539, #33542 - Failed merges: #33342, #33475, #33517

GuillaumeGomez mentioned this pull request May 11, 2016

Rollup of 3 pull requests #33562

Merged

eddyb mentioned this pull request May 12, 2016

Rollup of 15 pull requests #33589

Closed

eddyb mentioned this pull request May 12, 2016

Rollup of 21 pull requests #33595

Closed

eddyb mentioned this pull request May 12, 2016

Rollup of 23 pull requests #33597

Closed

eddyb mentioned this pull request May 13, 2016

Rollup of 29 pull requests #33610

Closed

sanxiyn mentioned this pull request May 14, 2016

Rollup of 15 pull requests #33629

Closed

eddyb mentioned this pull request May 14, 2016

Rollup of 27 pull requests #33643

Merged

Manishearth mentioned this pull request May 15, 2016

Rollup of 14 pull requests #33658

Merged

bors merged commit 843b174 into rust-lang:master May 15, 2016

birkenfeld deleted the issue-26472 branch May 22, 2016 06:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

typeck: if a private field exists, also check for a public method #33342

typeck: if a private field exists, also check for a public method #33342

birkenfeld commented May 2, 2016

rust-highfive commented May 2, 2016

arielb1 commented May 2, 2016

Nashenas88 commented May 3, 2016

steveklabnik commented May 5, 2016

steveklabnik commented May 5, 2016

birkenfeld commented May 6, 2016 •

edited

Loading

jseyfried May 10, 2016 •

edited

Loading

jseyfried commented May 10, 2016

birkenfeld commented May 10, 2016

jseyfried commented May 10, 2016

bors commented May 10, 2016

bors commented May 11, 2016

typeck: if a private field exists, also check for a public method #33342

typeck: if a private field exists, also check for a public method #33342

Conversation

birkenfeld commented May 2, 2016

rust-highfive commented May 2, 2016

arielb1 commented May 2, 2016

Nashenas88 commented May 3, 2016

steveklabnik commented May 5, 2016

steveklabnik commented May 5, 2016

birkenfeld commented May 6, 2016 • edited Loading

jseyfried May 10, 2016 • edited Loading

Choose a reason for hiding this comment

jseyfried commented May 10, 2016

birkenfeld commented May 10, 2016

jseyfried commented May 10, 2016

bors commented May 10, 2016

bors commented May 11, 2016

birkenfeld commented May 6, 2016 •

edited

Loading

jseyfried May 10, 2016 •

edited

Loading