Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rollup of 3 pull requests #33562

Merged
merged 10 commits into from
May 12, 2016
Merged

Rollup of 3 pull requests #33562

merged 10 commits into from
May 12, 2016

Conversation

GuillaumeGomez and others added 10 commits May 11, 2016 00:05
Add more comments for the global understanding
…pnkfelix

Add rustc_on_unimplemented for Index implementation on slice

Reopening of rust-lang#31071.

It also extends the possibility of `#[rustc_on_unimplemented]` by providing a small type filter in order to find the ones which corresponds the most.

r? @pnkfelix
…veklabnik

trivial tweaks to documentation (book)

These are small things I found while reading through The Book. The `<hash>` and `panic!` lines are simply to improve readability, while I believe the proceeding/following distinction is a bug (but might be a English dialect distinction?).

I've read `rust/CONTRIBUTING`, i'm not sure if there is anything I need to do other than submit this PR.

r? @steveklabnik
@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Collaborator

bors commented May 11, 2016

📌 Commit 10f9f30 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented May 11, 2016

⌛ Testing commit 10f9f30 with merge 22ac88f...

bors added a commit that referenced this pull request May 11, 2016
Rollup of 3 pull requests

- Successful merges: #33401, #33489, #33558
- Failed merges: #33342, #33475, #33517
@bors bors merged commit 10f9f30 into rust-lang:master May 12, 2016
@GuillaumeGomez GuillaumeGomez deleted the rollup branch May 12, 2016 16:52
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants