Rollup of 16 pull requests #36021
Closed
Rollup of 16 pull requests #36021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing otherwise would break traits like `ToString`.
This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples. add feature for inclusive_range_syntax fix incorrectly closed code fences
r? @steveklabnik add links for Box, Rc, and Vec
They're the same thing but it's better to keep the terminology consistent.
r? @steveklabnik add examples that lift `<<` and `>>` to a trivial struct replace `Scalar` structs with struct tuples add `fn main` wrappers to enable Rust Playground "Run" button
The affected API apparently had changed with commit d59accf.
Fixes rust-lang#35966. Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
Fixes rust-lang#35311. Part of rust-lang#35233. r? @jonathandturner
We originally imported this into the repository with the intent of fixing it up. Instead, nothing happened. Its appearance on rust-lang.org makes it seem semi-official, but it's not. The rustfmt strike team will end up producing something like this anyway, and leaving it around does nothing but mislead people.
Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground. simplified bitand expression add a comment explaining what "rhs" means
Remove style guide. We originally imported this into the repository with the intent of fixing it up. Instead, nothing happened. Its appearance on rust-lang.org makes it seem semi-official, but it's not. The rustfmt strike team will end up producing something like this anyway, and leaving it around does nothing but mislead people. r? @aturon
Update E0389 to the new format. rust-lang#35630
…les, r=steveklabnik refactor range examples This pull request adds a module-level example of how all the range operators work. It also slims down struct-level examples in lieu of a link to module examples.
…abnik Improve Path and PathBuf docs r? @steveklabnik
Clarify/fix formatting docs concerning fmt::Result/fmt::Error 1. `fmt::Result` != `io::Result<()>` 2. Formatters should only propagate errors, not return their own. Confusion on reddit: https://www.reddit.com/r/rust/comments/4yorxr/is_implt_tostring_for_t_where_t_display_sized_a/
…klabnik add evocative examples for `Shl` and `Shr` r? @steveklabnik
…klabnik add links to interesting items in `std::ptr` documentation r? @steveklabnik
…steveklabnik Updated code sample in chapter on syntax extensions. The affected API apparently had changed with commit d59accf. --- Further more I had to add ```toml [lib] name = "roman_numerals" crate-type = ["dylib"] ``` to `Cargo.toml` as I otherwise got this compiler error (despite `#![crate_type="dylib"]`): [E0457]: plugin `roman_numerals` only found in rlib format, but must be available in dylib format Might be worth adding a note about that?
Rename {int,uint} methods to {isize,usize}.
None
…turner Make E0094 underline better r? @jonathandturner
…thandturner Update E0277 to new error format Fixes rust-lang#35311. Part of rust-lang#35233. r? @jonathandturner
…thandturner Update E0453 to new error format Fixes rust-lang#35929. Part of rust-lang#35233. r? @jonathandturner
…=GuillaumeGomez improve `BitAnd` trait documentation This pull request is based on the discussion in PR rust-lang#35927. Add a module-level note that `&&` and `||` are short-circuiting operators and not overloadable. Add a simple `Scalar` example that lifts the `&` operator to a trivial struct tuple. Make `BooleanVector` a struct tuple. Derive `PartialEq` for `BooleanVector` instead of implementing it. Adds a `fn main` wrapper so that the example can integrate with Rust Playground.
…le, r=GuillaumeGomez add a simple example for `thread::current()` r? @GuillaumeGomez
…ndturner Err codes r? @jonathandturner
strengthen doc warning about CString::from_raw Saw unsound code using this function on IRC.
|
@bors: r+ p=1 |
|
📌 Commit bb1102a has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit bb1102a has been approved by |
|
⌛ Testing commit bb1102a with merge 501e031... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
@bors: retry |
|
⌛ Testing commit bb1102a with merge 7fafa38... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit bb1102a with merge b0909b0... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
☔ The latest upstream changes (presumably #36049) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Out of date now I think :( |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShlandShr#35863, add links to interesting items instd::ptrdocumentation #35880, Updated code sample in chapter on syntax extensions. #35962, Rename {int,uint} methods to {isize,usize}. #35977, Make E0094 underline better #35980, Update E0277 to new error format #35985, Update E0453 to new error format #35989, improveBitAndtrait documentation #35993, add a simple example forthread::current()#35997, Err codes #36003, strengthen doc warning about CString::from_raw #36018RangeToandRangeToInclusivefails #35771, improve documentation forFn*traits #35810