add evocative examples for Shl and Shr

[matthew-piziak]

r? @steveklabnik

[aravind-pg]

IMO this is a nice but unnecessarily sophisticated example, since the implementation involves some distractingly nontrivial vector manipulation. For documentation purposes is it not enough to just have say a struct Scalar(i64) with the obvious Shl/Shr implementation? After all the purpose here shouldn't be to suggest fun ideas for a Shl/Shr implementation but rather just to show concisely how it is done :)

[matthew-piziak]

@aravind-pg Yeah, that's a good point. I've added the examples you suggested. Do you think something like SpinVector has value as a secondary example?

[aravind-pg]

Sure, I personally quite like it, but I'm not sure what the policy is on having two separate examples in the documentation (I would think it leans towards a no, in the interest of brevity).

[steveklabnik]

In general, more examples are good; brevity isn't always a good thing when it comes to docs. There's obviously some kind of limit to this.

On Aug 21, 2016, 00:26 -0400, Aravind Gollakota notifications@github.com, wrote:

Sure, I personally quite like it, but I'm not sure what the policy is on having two separate examples in the documentation (I would think it leans towards a no, in the interest of brevity).

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub (#35863 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AABsitl01_34vXWAQ-GCg0MfqwfP0Vgwks5qh9OMgaJpZM4JpJhT).

[matthew-piziak]

Working on this PR started to feel like this after a while:

https://www.youtube.com/watch?v=1pAMdn9oSPE

[steveklabnik]

Looks great, thanks!

@bors: r+ rollup

[bors]

📌 Commit ff3a761 has been approved by steveklabnik

[bors]

⌛ Testing commit ff3a761 with merge a06c27e...

[bors]

💔 Test failed - auto-mac-64-opt-rustbuild

[arielb1]

@bors retry