-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Update error format for E0458, E0459 #36070
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Looks good! Thanks for the PR. @bors r+ rollup |
📌 Commit 852953c has been approved by |
- Fixes rust-lang#35933 - Part of rust-lang#35233 r? @jonathandturner
- Fixes rust-lang#35932 - Part of rust-lang#35233 r? @jonathandturner
@gavinb - since you've been changing the same PR, I'd like to just go ahead and merge one. Can you change the title to show all of the errors you've updated? |
@jonathandturner I didn't mean to change the same PR. I should have done the original changes on a separate branch and not rebased. Since I have a PR for E0164, E0165 and E0184 as #36125 which has already gone in, I'll chop those off my master branch and re-push to clear up the overlap. (Somehow they ended up on master as well as a dev branch. Erk.) |
This looks good. Let me know if it's ready, and I'll go ahead and approve. |
Yes, ready to go as far as I'm concerned. Thanks. |
Sounds good @bors r+ rollup |
📌 Commit 0412fa8 has been approved by |
Update error format for E0458, E0459 Fixes rust-lang#35933, rust-lang#35932 Part of rust-lang#35233 r? @jonathandturner
Update error format for E0458, E0459 Fixes rust-lang#35933, rust-lang#35932 Part of rust-lang#35233 r? @jonathandturner
Fixes #35933, #35932
Part of #35233
r? @jonathandturner