Fix ICE when printing closures, and other similar types #37491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
force-pushed
the
closure-ice
branch
from
7fc7bd8 to
0dfc046
Compare
|
@bors r+ |
|
📌 Commit 0dfc046 has been approved by |
eddyb
added
the
beta-nominated
|
Nominated for beta backporting, which would have to include #37459 - but just the latter is not enough. |
|
@bors p=1 |
This was referenced Nov 3, 2016
Merged
|
Approved for backport because @eddyb said so. =) cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
brson
removed
the
beta-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #37459, further fixes those problems.
Potentially actually fixes #36622, though @eddyb may want to not let that close if the rename of RUST_LOG is deemed part of that issue.
Potentially should be beta-nominated as well?
r? @eddyb