[beta] backports #37549
Merged
[beta] backports #37549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There used to be only a global cache, which led to uncached calls to trait selection when there were type parameters. I'm running a check that there are no adverse performance effects. Fixes rust-lang#37106 (drop elaboration times are now ~half of borrow checking, so might still be worthy of optimization, but not critical).
This will make it easier for packagers to bootstrap rustc when they happen to have a bootstrap compiler with a slightly different version number. It's not ok for anything other than the build system to set this environment variable.
The `specializes()` function was trying to normalize the impl trait in an empty environment. This could lead to inexplicable failures.
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
Oh, I'm also still testing this locally. |
|
r=me when approved |
|
Tests pass locally. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all outstanding backports for 1.13. Don't merge yet. Not all are accepted yet, nor tested on master. cc @rust-lang/compiler please review those noted below for acceptance.
impls_bound#37152After this beta is built we need to update master to pick up the new 1.13 cargo rev set in rust-lang-deprecated/rust-packaging#64.