Skip to content

Fix verify.rs #38029

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2016
Merged

Fix verify.rs #38029

merged 3 commits into from
Dec 4, 2016

Conversation

dns2utf8
Copy link
Contributor

Finishing d2f8fb0 from @jseyfried

@dns2utf8
Finishing d2f8fb0 from @jseyfried
0bcb05c
@dns2utf8
Resolve visibility issues
2dc3fdf 
use syntax::ast::Name; is a reexport of syntax::symbol::Symbol(u32);
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

dns2utf8
dns2utf8 commented Nov 27, 2016
View reviewed changes
src/libsyntax/symbol.rs
pub fn invalid() -> Self {
Symbol(0u32)
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to create this method because Symbol.0 is private. Is this ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbol(0) is already available as keywords::Invalid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keywords::Invalid.name() to be precise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thank you 😄

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 27, 2016

📌 Commit 28b64dc has been approved by petrochenkov

dns2utf8 added a commit to dns2utf8/rust that referenced this pull request Dec 1, 2016
@dns2utf8
Rollup merge of rust-lang#38029 - dns2utf8:fix_verify.rs, r=petrochenkov
b7ae05e 
Fix verify.rs

Finishing d2f8fb0 from @jseyfried
@dns2utf8 dns2utf8 mentioned this pull request Dec 1, 2016
Closed
@dns2utf8 dns2utf8 mentioned this pull request Dec 1, 2016
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 3, 2016
@frewsxcv
Rollup merge of rust-lang#38029 - dns2utf8:fix_verify.rs, r=petrochenkov
78c1046 
Fix verify.rs

Finishing d2f8fb0 from @jseyfried
@frewsxcv frewsxcv mentioned this pull request Dec 3, 2016
Merged
bors added a commit that referenced this pull request Dec 3, 2016
@bors
Auto merge of #38148 - frewsxcv:rollup, r=frewsxcv
28d6623 
Rollup of 15 pull requests

- Successful merges: #37859, #37919, #38020, #38028, #38029, #38065, #38073, #38077, #38089, #38090, #38096, #38112, #38113, #38130, #38141
- Failed merges:
@bors bors merged commit 28b64dc into rust-lang:master Dec 4, 2016
@dns2utf8 dns2utf8 deleted the fix_verify.rs branch December 4, 2016 00:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dns2utf8 @rust-highfive @petrochenkov @bors @nikomatsakis