Skip to content

Add Component examples #38141

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2016
Merged

Add Component examples #38141

merged 1 commit into from
Dec 4, 2016

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Member

frewsxcv commented Dec 3, 2016

Looks good, but will it fail on Windows since it uses \ as the main path separator?

@frewsxcv
Copy link
Member

frewsxcv commented Dec 3, 2016

Nevermind, it seems to work for other examples in that module.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 3, 2016

📌 Commit 60d1660 has been approved by frewsxcv

@GuillaumeGomez
Copy link
Member Author

Windows handles '/' just like ''.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 3, 2016
@frewsxcv
Rollup merge of rust-lang#38141 - GuillaumeGomez:component_doc, r=fre…
2e038ed 
…wsxcv

Add Component examples

r? @frewsxcv
@frewsxcv frewsxcv mentioned this pull request Dec 3, 2016
Merged
bors added a commit that referenced this pull request Dec 3, 2016
@bors
Auto merge of #38148 - frewsxcv:rollup, r=frewsxcv
28d6623 
Rollup of 15 pull requests

- Successful merges: #37859, #37919, #38020, #38028, #38029, #38065, #38073, #38077, #38089, #38090, #38096, #38112, #38113, #38130, #38141
- Failed merges:
@bors bors merged commit 60d1660 into rust-lang:master Dec 4, 2016
@GuillaumeGomez GuillaumeGomez deleted the component_doc branch December 4, 2016 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @frewsxcv @bors