Miscellaneous cleanup/refactoring in resolve and syntax::ext
#38171
Conversation
| @@ -475,8 +475,6 @@ pub struct MacroDef { | |||
| pub attrs: HirVec<Attribute>, | |||
| pub id: NodeId, | |||
| pub span: Span, | |||
| pub imported_from: Option<Name>, | |||
There was a problem hiding this comment.
This was always None due to #37213.
jseyfried
force-pushed
the
cleanup
branch
4 times, most recently
from
e8a6dfa to
63cfb39
Compare
jseyfried
force-pushed
the
cleanup
branch
2 times, most recently
from
1331be9 to
33e2ea3
Compare
| @@ -160,7 +155,13 @@ pub struct PathSegment { | |||
| /// this is more than just simple syntactic sugar; the use of | |||
| /// parens affects the region binding rules, so we preserve the | |||
| /// distinction. | |||
| pub parameters: PathParameters, | |||
| pub parameters: Option<P<PathParameters>>, | |||
There was a problem hiding this comment.
Does this introduce distinction between segment and segment::<> or is it purely a size optimization?
There was a problem hiding this comment.
I amended so that it is purely a size optimization.
There was a problem hiding this comment.
Could you add a comment telling that this is a size optimization and what None means?
jseyfried
force-pushed
the
cleanup
branch
2 times, most recently
from
eaff87f to
6d7f6e5
Compare
|
☔ The latest upstream changes (presumably #38369) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me with the comment @petrochenkov requested |
|
@bors r=nrc |
|
📌 Commit f705c69 has been approved by |
|
⌛ Testing commit f705c69 with merge 5a825c8... |
|
💔 Test failed - auto-win-msvc-64-opt |
|
@bors: retry
…On Mon, Dec 19, 2016 at 6:16 PM, bors ***@***.***> wrote:
💔 Test failed - auto-win-msvc-64-opt
<https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/6473>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38171 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HyNSN1eTMn0IY4PFuFvCGgdM5QKks5rJzqBgaJpZM4LD2c->
.
|
Miscellaneous cleanup/refactoring in `resolve` and `syntax::ext` r? @nrc
|
☔ The latest upstream changes (presumably #38271) made this pull request unmergeable. Please resolve the merge conflicts. |
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
|
This merged in #38499. |
r? @nrc