static recursion test added to compile-fail test suite #39834
Conversation
| prev: &'static StaticDoubleLinked, | ||
| next: &'static StaticDoubleLinked, | ||
| data: i32, | ||
| head: bool |
There was a problem hiding this comment.
nit: trailing commas are more idiomatic
| @@ -0,0 +1,48 @@ | |||
| // Copyright 2015 The Rust Project Developers. See the COPYRIGHT | |||
| static L3: StaticDoubleLinked = StaticDoubleLinked{prev: &L2, next: &L1, data: 3, head: false}; | ||
| //~^^^ ERROR recursive static (see issue #29719) | ||
| //~^^^^ ERROR recursive static (see issue #29719) | ||
| //~^^^^^ ERROR recursive static (see issue #29719) |
There was a problem hiding this comment.
nit: interleaving these errors with the code is more idiomatic
|
@bors delegate=est31 |
|
✌️ @est31 can now approve this pull request |
cseale
force-pushed
the
feature-gate-static-recursion
branch
from
fdf478a to
cf20d8e
Compare
| static L1: StaticDoubleLinked = StaticDoubleLinked{prev: &L3, next: &L2, data: 1, head: true}; | ||
| //~^ ERROR recursive static (see issue #29719) | ||
| //~^^ ERROR recursive static (see issue #29719) | ||
| //~^^^ ERROR recursive static (see issue #29719) |
There was a problem hiding this comment.
This won't work, and is not what @jseyfried meant. Just make one line of code, followed by one line of comment, then one line of code, etc.
There was a problem hiding this comment.
Yeah, I figured, it's just that the problem here is that it complains that the issue is always at line 21, and it is expecting 3 errors, which is confusing to me. Any ideas on why that is happening
There was a problem hiding this comment.
this:
static L1: StaticDoubleLinked = StaticDoubleLinked{prev: &L3, next: &L2, data: 1, head: true};
//~^ ERROR recursive static (see issue #29719)
static L2: StaticDoubleLinked = StaticDoubleLinked{prev: &L1, next: &L3, data: 2, head: false};
//~^ ERROR recursive static (see issue #29719)
static L3: StaticDoubleLinked = StaticDoubleLinked{prev: &L2, next: &L1, data: 3, head: false};
//~^ ERROR recursive static (see issue #29719)
fails with this error:
unexpected errors (from JSON output): [
Error {
line_num: 21,
kind: Some(
Error
),
msg: "21:1: 21:95: recursive static (see issue #29719)"
},
Error {
line_num: 21,
kind: Some(
Error
),
msg: "21:1: 21:95: recursive static (see issue #29719)"
}
]
not found errors (from test file): [
Error {
line_num: 23,
kind: Some(
Error
),
msg: "recursive static (see issue #29719)"
},
Error {
line_num: 25,
kind: Some(
Error
),
msg: "recursive static (see issue #29719)"
}
]
Sorry, I probably should have led with this in the comments as opposed to making a dumb looking edit. I don't understand why line 21 throws 3 of the same error
There was a problem hiding this comment.
Hmm seems its a bug or something. See, that's why we are adding these tests.
There was a problem hiding this comment.
I think I'll approve it and then file a PR to fix the error message bug.
There was a problem hiding this comment.
Hmm seems its more complicated than I thought. I think I'll let it be, its "only" a feature gate test. But I'll file an issue so that it doesn't get forgotten.
|
@bors r+ |
|
📌 Commit cf20d8e has been approved by |
…n, r=est31 static recursion test added to compile-fail test suite Issue rust-lang#39059 r? @est31
…n, r=est31 static recursion test added to compile-fail test suite Issue rust-lang#39059 r? @est31
…n, r=est31 static recursion test added to compile-fail test suite Issue rust-lang#39059 r? @est31
Issue #39059
r? @est31