Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sys/mod doc update and mod import order adjust #39844

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Conversation

king6cong
Copy link
Contributor

  • Some doc updates.
  • Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 15, 2017

📌 Commit b821313 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 15, 2017
sys/mod doc update and mod import order adjust

* Some doc updates.
* Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.
bors added a commit that referenced this pull request Feb 16, 2017
Rollup of 11 pull requests

- Successful merges: #39775, #39793, #39804, #39824, #39834, #39837, #39839, #39840, #39843, #39844, #39846
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
sys/mod doc update and mod import order adjust

* Some doc updates.
* Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
sys/mod doc update and mod import order adjust

* Some doc updates.
* Racer currently use the first mod it finds regardless of cfg attrs. Moving #[cfg(unix)] up should be a temporary tweak that works as expected for more people.
bors added a commit that referenced this pull request Feb 16, 2017
Rollup of 12 pull requests

- Successful merges: #39775, #39793, #39804, #39834, #39836, #39839, #39840, #39843, #39844, #39846, #39857, #39861
- Failed merges:
@bors bors merged commit b821313 into rust-lang:master Feb 16, 2017
@lilianmoraru
Copy link

lilianmoraru commented Mar 5, 2017

@king6cong @alexcrichton
Using #[cfg(target_os = "redox")] seems problematic to me.
You can have the host unix/windows and the target redox - shouldn't there be conflicts?
If this works for reasons I don't understand, than think of the build.rs "script".
A crate like tempdir(it's not the best example in the case of tmp, think setenv function), how does it decide which implementation of temp_dir() to use. It has to work in build.rs and also in an application that runs in redox.

Edit: In the case of build.rs I think I confused things. It will be built 2 times, for host(for build.rs) and then again for the binary/library.

Edit2: Now seems to me that the other 2 are incorrect.
Shouldn't it be target_os for all? What if you cross-compile?
Did anyone try to cross-compile to unix targets from Windows?
It seems to me you should not be able to cross-compile from Windows to emscripten as an example.

@alexcrichton
Copy link
Member

@lilianmoraru oh it may make sense if I say that unix/windows/redox are all mutually exclusive, so only one of these modules ever exists.

@lilianmoraru
Copy link

I confused cfg ([os]) meaning cfg(host_os) instead of cfg (target_family)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants