std: Don't cache stdio handles on Windows #40516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added
the
T-libs-api
|
@bors: r+ |
|
📌 Commit af72b06 has been approved by |
|
🔒 Merge conflict |
This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
alexcrichton
force-pushed
the
no-cache-handles
branch
from
af72b06 to
5ca8a73
Compare
|
@bors: r=aturon |
|
📌 Commit 5ca8a73 has been approved by |
|
⌛ Testing commit 5ca8a73 with merge b1d0e15... |
|
💔 Test failed - status-travis |
|
@bors: retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 25, 2017
…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
|
⌛ Testing commit 5ca8a73 with merge d11f245... |
|
💔 Test failed - status-travis |
|
⌛ Testing commit 5ca8a73 with merge 25c8108... |
|
💔 Test failed - status-travis |
|
⌛ Testing commit 5ca8a73 with merge f4f9468... |
|
💔 Test failed - status-travis |
bors
added a commit
that referenced
this pull request
Mar 26, 2017
std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes #40490
|
💔 Test failed - status-appveyor |
|
… On Sun, Mar 26, 2017 at 2:37 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2570>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40516 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95L7xpobTPOKTiRwcbsAEgD3AGmcRks5rpr5ngaJpZM4McsLJ>
.
|
bors
added a commit
that referenced
this pull request
Mar 27, 2017
std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes #40490
@bors retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2017
…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
bors
added a commit
that referenced
this pull request
Mar 27, 2017
bors
added a commit
that referenced
this pull request
Mar 28, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the stdio code on Windows to always call
GetStdHandlewhenever thestdio read/write functions are called as this allows us to track changes to the
value over time (such as if a process calls
SetStdHandlewhile it's running).Closes #40490