-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Convert Intos to Froms. #42129
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert Intos to Froms. #42129
Conversation
r? @BurntSushi (rust_highfive has picked a reviewer for you, use r? to override) |
Travis failed:
|
In principle this seems fine to me, if you can get it to work. However, are there any backward compatibility/inference failure hazards? Should this get a crater run? |
@BurntSushi doesn't require crater run because |
Right. I understand it shouldn't. But I've been fooled by things like this in the past. :-) |
Ah yeah unfortunately these impls are not possible due to coherence. In that case I'm going to close this. |
I believe it's only |
Ah ok! Want to send a PR with those implementations? |
Sure: #42227 |
Thanks @ollie27 for beating me to it |
Convert Intos to Froms. This is a resubmission of #42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
Convert Intos to Froms. This is a resubmission of #42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>` As the `collections` crate has been merged into `alloc` in rust-lang#42648 this impl is now possible. This is the final part of rust-lang#42129 missing from rust-lang#42227.
Convert Intos to Froms. This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
Convert Intos to Froms. This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
This didn't work before but supposedly this should work now. It's better to have
From
impls overInto
.