Skip to content

Convert Intos to Froms. #42227

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2017
Merged

Convert Intos to Froms. #42227

merged 2 commits into from
Jul 4, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented May 25, 2017

This is a resubmission of #42129 without impl<T> From<Vec<T>> for Box<[T]>.

@rust-highfive
Copy link
Contributor

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@ollie27 ollie27 mentioned this pull request May 25, 2017
Closed
@BurntSushi
Copy link
Member

As with #42129, I'd still feel better with a crater run.

@BurntSushi BurntSushi added S-waiting-on-crater Status: Waiting on a crater run to be completed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 25, 2017
@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 27, 2017
@aidanhs aidanhs added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2017
@Mark-Simulacrum
Copy link
Member

Infra team is experimenting....

@bors try

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Trying commit 30bbcef with merge 8da3914...

bors added a commit that referenced this pull request Jun 4, 2017
@bors
Auto merge of #42227 - ollie27:into_to_from, r=<try>
8da3914 
Convert Intos to Froms.

This is a resubmission of #42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
@bors
Copy link
Collaborator

bors commented Jun 4, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member

frewsxcv commented Jun 4, 2017

@bors retry

travis cancelled one of the builds

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Trying commit 30bbcef with merge 98629a9...

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

Intentionally canceled build -- we need to land another PR before try builds make sense.

@Mark-Simulacrum
Copy link
Member

@bors try

Getting artifacts for cargobomb.

@Mark-Simulacrum
Copy link
Member

Oh, I guess it needs to retry try?

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 4, 2017

⌛ Trying commit 30bbcef with merge 0964ee3...

@frewsxcv
Copy link
Member

frewsxcv commented Jun 5, 2017

@bors retry

@brson
Copy link
Contributor

brson commented Jun 5, 2017

I've deployed a new build of crater. Will try this one.

@brson
Copy link
Contributor

brson commented Jun 5, 2017

Building toolchains

@brson
Copy link
Contributor

brson commented Jun 6, 2017

Messed up the previous commands. Here are the new jobs:

@arielb1 arielb1 removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jun 6, 2017
@brson
Copy link
Contributor

brson commented Jun 6, 2017

Still fixing crater:

@arielb1 arielb1 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2017
@arielb1
Copy link
Contributor

arielb1 commented Jun 13, 2017

Isn't @aturon on vacation right now? I think this PR has been open long enough that we'll just wait for him for the final signoff.

@bors
Copy link
Collaborator

bors commented Jun 15, 2017

☔ The latest upstream changes (presumably #42648) made this pull request unmergeable. Please resolve the merge conflicts.

@clarfonthey
Copy link
Contributor

Small nudge to point out that this can add back the Vec implementation now that alloc and collections are merged.

@ollie27 ollie27 mentioned this pull request Jun 17, 2017
Merged
@ollie27
Copy link
Member Author

ollie27 commented Jun 17, 2017

Rebased. I've submitted the Vec impl separately (#42717) to avoid holding up this PR any longer.

bors added a commit that referenced this pull request Jun 17, 2017
@bors
Auto merge of #42717 - ollie27:into_to_from2, r=<try>
5311126 
Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>`

As the `collections` crate has been merged into `alloc` in #42648 this impl is now possible. This is the final part of #42129 missing from #42227.
@bors
Copy link
Collaborator

bors commented Jun 20, 2017

☔ The latest upstream changes (presumably #42716) made this pull request unmergeable. Please resolve the merge conflicts.

@arielb1 arielb1 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 20, 2017
@frewsxcv
Rollup merge of rust-lang#42717 - ollie27:into_to_from2, r=sfackler
dbe16e0 
Convert `Into<Box<[T]>> for Vec<T>` into `From<Vec<T>> for Box<[T]>`

As the `collections` crate has been merged into `alloc` in rust-lang#42648 this impl is now possible. This is the final part of rust-lang#42129 missing from rust-lang#42227.
@Mark-Simulacrum
Copy link
Member

@aturon I think this is ready for merge but not quite sure...

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2017
@aidanhs
Copy link
Member

aidanhs commented Jun 28, 2017

I've pinged @aturon, but I suspect he's not going to get to this until next week.

@aturon
Copy link
Member

aturon commented Jul 3, 2017

@bors: r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Jul 3, 2017

📌 Commit 0d885ef has been approved by aturon

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42227 - ollie27:into_to_from, r=aturon
0f8998d 
Convert Intos to Froms.

This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42227 - ollie27:into_to_from, r=aturon
32cbbff 
Convert Intos to Froms.

This is a resubmission of rust-lang#42129 without `impl<T> From<Vec<T>> for Box<[T]>`.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2017
Merged
bors added a commit that referenced this pull request Jul 4, 2017
@bors
Auto merge of #43051 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
2fbba5b 
Rollup of 8 pull requests

- Successful merges: #42227, #42836, #42975, #42994, #43041, #43042, #43043, #43045
- Failed merges:
@bors bors merged commit 0d885ef into rust-lang:master Jul 4, 2017
@ollie27 ollie27 deleted the into_to_from branch July 4, 2017 19:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.