Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[beta] Stabilize unions with Copy fields and no destructor #42321

Closed
wants to merge 2 commits into from
Closed

[beta] Stabilize unions with Copy fields and no destructor #42321

wants to merge 2 commits into from

Conversation

brson
Copy link
Contributor

@brson brson commented May 31, 2017 •
edited
Loading

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@brson
Copy link
Contributor Author

brson commented May 31, 2017

Testing locally while we try to land via bors.

@aturon
Copy link
Member

aturon commented May 31, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented May 31, 2017

📌 Commit b112c27 has been approved by aturon

@Mark-Simulacrum
Copy link
Member

@bors p=10 (beta backport with short time remaining)

@petrochenkov
Copy link
Contributor

@brson @aturon
You may want to backport #42083 as well, they were supposed to land together.

@bors
Copy link
Contributor

bors commented May 31, 2017

⌛ Testing commit b112c27 with merge 6ed6494...

@bors
Copy link
Contributor

bors commented May 31, 2017

💔 Test failed - status-travis

@petrochenkov petrochenkov mentioned this pull request May 31, 2017
Closed
@petrochenkov
Copy link
Contributor

I've submitted #42328 including #42083 and fixing discrepancies between beta and nightly causing the Travis failure.

@brson
Copy link
Contributor Author

brson commented May 31, 2017

Closing in favor of #42328

@brson brson closed this May 31, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brson @rust-highfive @aturon @bors @Mark-Simulacrum @petrochenkov