Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[beta] Backport union stabilization PRs #42328

Closed
wants to merge 4 commits into from

Conversation

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@est31
Copy link
Member

est31 commented May 31, 2017

I think this should be put into the release notes, no?

@brson
Copy link
Contributor

brson commented May 31, 2017

I'm going to update the relnotes and backport as part of this pr.

@brson
Copy link
Contributor

brson commented May 31, 2017

This isn't backporting the reference docs, and it probably should.

@brson
Copy link
Contributor

brson commented May 31, 2017

There's no beta branch of the reference to backport the reference docs to.

I'm feeling a bit uncomfortable about this.

@nikomatsakis
Copy link
Contributor

I'll copy my comment from #42068:

"I don't strongly object, but I'm surprised we would backport this. I feel like we try to keep backports to regressions or important bug fixes, and only rarely backport stabilizations -- the exception would be if some feature is hotly demanded. But otoh this seems pretty darn low risk, so no real objection."

@brson
Copy link
Contributor

brson commented May 31, 2017

I'm going to look into backporting the reference directly from reference/master and see if it makes sense on beta.

@brson
Copy link
Contributor

brson commented May 31, 2017

Here's the reference diff: rust-lang/reference@6b0de90...master

@brson
Copy link
Contributor

brson commented May 31, 2017

Let's not do it. Feels risky to me.

@brson brson closed this May 31, 2017
@lilianmoraru
Copy link

So, this did not land?
The release notes say that it landed: https://github.com/rust-lang/rust/pull/42503/files#diff-5cafcf46bfb947f8e58fa5c16d39018cR13

@petrochenkov petrochenkov deleted the beta branch August 26, 2017 00:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants