-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[beta] Backport union stabilization PRs #42328
Conversation
I think this should be put into the release notes, no? |
I'm going to update the relnotes and backport as part of this pr. |
This isn't backporting the reference docs, and it probably should. |
There's no beta branch of the reference to backport the reference docs to. I'm feeling a bit uncomfortable about this. |
I'll copy my comment from #42068: "I don't strongly object, but I'm surprised we would backport this. I feel like we try to keep backports to regressions or important bug fixes, and only rarely backport stabilizations -- the exception would be if some feature is hotly demanded. But otoh this seems pretty darn low risk, so no real objection." |
I'm going to look into backporting the reference directly from reference/master and see if it makes sense on beta. |
Here's the reference diff: rust-lang/reference@6b0de90...master |
Let's not do it. Feels risky to me. |
So, this did not land? |
Supersedes #42321
Copy
fields and no destructor #42068Copy
union fields safe #42083cc @aturon
r? @brson