Skip to content

Include rustc in the default ./x.py install #44353

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2017
Merged

Include rustc in the default ./x.py install #44353

merged 1 commit into from
Sep 7, 2017

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Sep 5, 2017

The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds. This commit makes rustc installed by default again.

@cuviper
Include rustc in the default ./x.py install
110efe2 
The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds.  This commit makes rustc installed by default again.
@cuviper
Copy link
Member Author

cuviper commented Sep 5, 2017

In particular, the change was here, formerly using default(true) and then using builder.build.config.extended. I suspect that was just an accident, cut-and-paste from other install clauses.

This needs to be fixed in beta too.

@Mark-Simulacrum Mark-Simulacrum self-requested a review September 5, 2017 23:06
@Mark-Simulacrum Mark-Simulacrum self-assigned this Sep 5, 2017
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 5, 2017
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 5, 2017

📌 Commit 110efe2 has been approved by Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 5, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44353 - cuviper:install-rustc, r=Mark-Simul…
c447c3b 
…acrum

Include rustc in the default `./x.py install`

The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds.  This commit makes rustc installed by default again.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 6, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44353 - cuviper:install-rustc, r=Mark-Simul…
eba44f1 
…acrum

Include rustc in the default `./x.py install`

The default install used to include rustc, rust-std, and rust-docs, but
the refactoring in commit 6b3413d make rustc only default in
extended builds.  This commit makes rustc installed by default again.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit 110efe2 into rust-lang:master Sep 7, 2017
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 12, 2017
@alexcrichton alexcrichton mentioned this pull request Sep 14, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 14, 2017
@cuviper cuviper deleted the install-rustc branch September 26, 2017 06:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cuviper @Mark-Simulacrum @bors @alexcrichton