Skip to content

Fix a bug in the inliner #44362

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2017
Merged

Fix a bug in the inliner #44362

merged 2 commits into from
Sep 7, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 6, 2017

r? @eddyb

@oli-obk oli-obk mentioned this pull request Sep 6, 2017
Merged
@RalfJung
Copy link
Member

RalfJung commented Sep 6, 2017

You can trigger this bug without miri being involved by running the following in the miri directory:

xargo/build.sh # do get a libstd with all the MIR, which means the MIR inliner has more options
rustc -Zmir-opt-level=3 --sysroot=$HOME/.xargo/HOST tests/run-pass-fullmir/unsized-tuple-impls.rs

@eddyb
Copy link
Member

eddyb commented Sep 6, 2017

This isn't a complete fix... I screwed up. I had return on both *local = l places, but then didn't need to return the value so I removed return but now it's wrong (both args and ret ptr).

@eddyb
Copy link
Member

eddyb commented Sep 6, 2017

@bors r+ Thanks!

@bors
Copy link
Collaborator

bors commented Sep 6, 2017

📌 Commit 5bb870f has been approved by eddyb

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44362 - oli-obk:patch-7, r=eddyb
ab729fb 
Fix a bug in the inliner

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 6, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44362 - oli-obk:patch-7, r=eddyb
435a5cd 
Fix a bug in the inliner

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit 5bb870f into rust-lang:master Sep 7, 2017
@oli-obk oli-obk deleted the patch-7 branch June 15, 2020 15:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @RalfJung @eddyb @bors @Mark-Simulacrum @alexcrichton