-
Notifications
You must be signed in to change notification settings - Fork 13.4k
stabilized iterator_for_each (closes #42986) #44567
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
61b8dff
to
d94dab7
Compare
Failed to start the CI. Please update
|
This needs to wait for completed FCP, right? |
@cuviper according to https://internals.rust-lang.org/t/stabilizing-apis-in-the-standard-library/5906, it is ready once all team member checked their boxes, there's no need to wait for the FCP to end.
|
d94dab7
to
b0655b1
Compare
@kennytm Updated with Cargo.lock. Sorry about that!
@alexcrichton The submodule updates were intentional due to rls and clipy depending on iterator_for_each. I've made PR's to their respective repos (rls, clippy) and updated the submodules to the PR commits according to this section in CONTRIBUTING.md I might have misunderstood the instructions so I will be glad to fix any problems! |
You're the first person to follow said instructions. Thanks! If any problems show up with the process it's with the instructions and not you ;) Travis seems to like it so far. |
@bors: r+ Ah ok, thanks! |
📌 Commit b0655b1 has been approved by |
@bors: r- Er actually, we prefer that our submodules are attached to long-lived commits which are at least somewhat relatively guaranteed to stick around into the future. In that sense the section of the contributing docs is wrong I believe in that we don't want to pin our submodules to PRs. Does stabilization here cause build failures? If not can the submodule updates happen later on the master branch? |
The stabilization will cause build failure for rls and test failure in clippy. I believe that we have a chicken and egg problem here and the stabilization and submodule PR's should proceed in lockstep (submodules first to generate a long lived commit and shortly then the lang repo). But this is is actually a question to the maintainers 😄. |
You can ignore clippy for now as we're not building it anyway, but for the rls we'll need to make a long-lived branch, which you can coordinate with @nrc for that |
b0655b1
to
8772227
Compare
@nrc can you make a branch of the RLS for this? |
@alexcrichton The PR is already on a branch |
@bors: r+ Aha, great! |
📌 Commit 8772227 has been approved by |
@bors: rollup |
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
8772227
to
b715290
Compare
Rebased! |
@bors: r+ |
📌 Commit b715290 has been approved by |
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
… r=alexcrichton stabilized iterator_for_each (closes rust-lang#42986) Also updated clippy and rls as these use the iterator_for_each I've made my first PR's today so most likely I've done something wrong. Sorry about that!
This includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640
This includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640
[beta] Backport accepted PRs to 1.21 Backport of: - ~don't suggest placing `use` statements into expanded code #44215 - stabilize tcpstream_connect_timeout #44563 - stabilized iterator_for_each #44567 - travis: Move sccache to the us-west-1 region #44574 - stabilized ord_max_min #44593 - stabilized compiler_fences #44595 - ci: Upload/download from a new S3 bucket #44617 - stabilized needs_drop #44639 - Stabilized vec_splice and modified splice tracking issue #44640 - Backport libs stabilizations to 1.21 beta #44824
Backport libs stabilizations to 1.21 beta Includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640 These have been backported in rust-lang#44823.
…veklabnik Corrected the CONTRIBUTING.md "External Dependencies" section The "External Dependencies" section is a little outdated. Please see following comments rust-lang#44567 (comment) rust-lang#44567 (comment) for rationale.
Also updated clippy and rls as these use the iterator_for_each
I've made my first PR's today so most likely I've done something wrong. Sorry about that!