Skip to content

stabilized iterator_for_each (closes #42986) #44567

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2017
Merged

stabilized iterator_for_each (closes #42986) #44567

merged 1 commit into from
Sep 17, 2017

Conversation

budziq
Copy link
Contributor

@budziq budziq commented Sep 14, 2017

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!

@budziq budziq force-pushed the stabilize_iterator_for_each branch from 61b8dff to d94dab7 Compare September 14, 2017 14:21
@kennytm
Copy link
Member

kennytm commented Sep 14, 2017

Failed to start the CI. Please update src/Cargo.lock.

[00:00:49] error: the lock file needs to be updated but --frozen was passed to prevent this

@cuviper
Copy link
Member

cuviper commented Sep 14, 2017

This needs to wait for completed FCP, right?

@kennytm
Copy link
Member

kennytm commented Sep 14, 2017

@cuviper according to https://internals.rust-lang.org/t/stabilizing-apis-in-the-standard-library/5906, it is ready once all team member checked their boxes, there's no need to wait for the FCP to end.

once all libs members have checked their checkboxes the issue is tagged with final-comment-period meaning it’s ready for stabilization.

@alexcrichton
Copy link
Member

Looks great to me, thanks @budziq! Looks like some stray submodule updates were included though?

@cuviper yeah for APIs we don't wait for the FCP to end, we just go ahead and throw them in once the team has signed off.

@alexcrichton alexcrichton self-assigned this Sep 14, 2017
@alexcrichton alexcrichton added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 14, 2017
@budziq budziq mentioned this pull request Sep 15, 2017
Closed
@budziq budziq force-pushed the stabilize_iterator_for_each branch from d94dab7 to b0655b1 Compare September 15, 2017 07:49
@budziq
Copy link
Contributor Author

budziq commented Sep 15, 2017

Failed to start the CI. Please update src/Cargo.lock.

@kennytm Updated with Cargo.lock. Sorry about that!

Looks like some stray submodule updates were included though?

@alexcrichton The submodule updates were intentional due to rls and clipy depending on iterator_for_each. I've made PR's to their respective repos (rls, clippy) and updated the submodules to the PR commits according to this section in CONTRIBUTING.md

I might have misunderstood the instructions so I will be glad to fix any problems!

@oli-obk
Copy link
Contributor

oli-obk commented Sep 15, 2017 •
edited
Loading

I might have misunderstood the instructions so I will be glad to fix any problems!

You're the first person to follow said instructions. Thanks!

If any problems show up with the process it's with the instructions and not you ;) Travis seems to like it so far.

@alexcrichton
Copy link
Member

@bors: r+

Ah ok, thanks!

@bors
Copy link
Collaborator

bors commented Sep 15, 2017

📌 Commit b0655b1 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: r-

Er actually, we prefer that our submodules are attached to long-lived commits which are at least somewhat relatively guaranteed to stick around into the future. In that sense the section of the contributing docs is wrong I believe in that we don't want to pin our submodules to PRs.

Does stabilization here cause build failures? If not can the submodule updates happen later on the master branch?

@budziq
Copy link
Contributor Author

budziq commented Sep 15, 2017

Does stabilization here cause build failures?

The stabilization will cause build failure for rls and test failure in clippy. I believe that we have a chicken and egg problem here and the stabilization and submodule PR's should proceed in lockstep (submodules first to generate a long lived commit and shortly then the lang repo). But this is is actually a question to the maintainers 😄.

@alexcrichton
Copy link
Member

You can ignore clippy for now as we're not building it anyway, but for the rls we'll need to make a long-lived branch, which you can coordinate with @nrc for that

@budziq budziq force-pushed the stabilize_iterator_for_each branch from b0655b1 to 8772227 Compare September 15, 2017 15:07
@alexcrichton
Copy link
Member

@nrc can you make a branch of the RLS for this?

@budziq
Copy link
Contributor Author

budziq commented Sep 15, 2017

@alexcrichton The PR is already on a branch

@alexcrichton
Copy link
Member

@bors: r+

Aha, great!

@bors
Copy link
Collaborator

bors commented Sep 15, 2017

📌 Commit 8772227 has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bors: rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 16, 2017
@alexcrichton
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
9da941f 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
@alexcrichton alexcrichton mentioned this pull request Sep 16, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 16, 2017
@frewsxcv
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
20ae064 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
@frewsxcv frewsxcv mentioned this pull request Sep 16, 2017
Closed
@budziq budziq force-pushed the stabilize_iterator_for_each branch from 8772227 to b715290 Compare September 16, 2017 21:14
@budziq
Copy link
Contributor Author

budziq commented Sep 16, 2017

Rebased!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Sep 16, 2017

📌 Commit b715290 has been approved by alexcrichton

bors added a commit that referenced this pull request Sep 17, 2017
@bors
Auto merge of #44634 - alexcrichton:rollup, r=alexcrichton
71e3767 
Rollup of 19 pull requests

- Successful merges: #44273, #44356, #44395, #44531, #44537, #44542, #44560, #44567, #44574, #44577, #44586, #44589, #44590, #44593, #44598, #44606, #44609, #44616, #44631
- Failed merges:
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
a0920b8 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
@TimNN TimNN mentioned this pull request Sep 17, 2017
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
640dcef 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
@TimNN TimNN mentioned this pull request Sep 17, 2017
Closed
TimNN added a commit to TimNN/rust that referenced this pull request Sep 17, 2017
@TimNN
Rollup merge of rust-lang#44567 - budziq:stabilize_iterator_for_each,…
1437e53 
… r=alexcrichton

stabilized iterator_for_each (closes rust-lang#42986)

Also updated clippy and rls as these use the iterator_for_each

I've made my first PR's today so most likely I've done something wrong. Sorry about that!
@TimNN TimNN mentioned this pull request Sep 17, 2017
Merged
bors added a commit that referenced this pull request Sep 17, 2017
@bors
Auto merge of #44654 - TimNN:rollup, r=TimNN
1cdd689 
Rollup of 17 pull requests

- Successful merges: #44073, #44088, #44381, #44397, #44509, #44533, #44549, #44553, #44562, #44567, #44595, #44604, #44617, #44622, #44630, #44639, #44647
- Failed merges:
@bors bors merged commit b715290 into rust-lang:master Sep 17, 2017
@budziq budziq deleted the stabilize_iterator_for_each branch September 17, 2017 17:11
@budziq budziq mentioned this pull request Sep 17, 2017
Merged
@dtolnay dtolnay added relnotes Marks issues that should be documented in the release notes of the next release. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2017
@dtolnay dtolnay mentioned this pull request Sep 21, 2017
Merged
@dtolnay dtolnay added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 21, 2017
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 25, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
874124b 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
This was referenced Sep 25, 2017
Merged
Closed
dtolnay added a commit to dtolnay/rust that referenced this pull request Sep 26, 2017
@dtolnay
Backport libs stabilizations to 1.21 beta
a8117df 
This includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640
bors added a commit that referenced this pull request Sep 26, 2017
@bors
Auto merge of #44823 - dtolnay:backport21, r=alexcrichton
3c3cd3f 
[beta] Backport accepted PRs to 1.21

Backport of:

- ~don't suggest placing `use` statements into expanded code #44215
- stabilize tcpstream_connect_timeout #44563
- stabilized iterator_for_each #44567
- travis: Move sccache to the us-west-1 region #44574
- stabilized ord_max_min #44593
- stabilized compiler_fences #44595
- ci: Upload/download from a new S3 bucket #44617
- stabilized needs_drop #44639
- Stabilized vec_splice and modified splice tracking issue #44640
- Backport libs stabilizations to 1.21 beta #44824
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44824 - dtolnay:22really21, r=alexcrichton
570f1ce 
Backport libs stabilizations to 1.21 beta

Includes the following stabilizations:

- tcpstream_connect_timeout rust-lang#44563
- iterator_for_each rust-lang#44567
- ord_max_min rust-lang#44593
- compiler_fences rust-lang#44595
- needs_drop rust-lang#44639
- vec_splice rust-lang#44640

These have been backported in rust-lang#44823.
kennytm added a commit to kennytm/rust that referenced this pull request Oct 5, 2017
@kennytm
Rollup merge of rust-lang#44664 - budziq:contributing_external, r=ste…
b34ade0 
…veklabnik

Corrected the CONTRIBUTING.md "External Dependencies" section

The "External Dependencies" section is a little outdated.
Please see following comments rust-lang#44567 (comment) rust-lang#44567 (comment) for rationale.
@dtolnay dtolnay mentioned this pull request Oct 10, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@budziq @kennytm @cuviper @alexcrichton @oli-obk @bors @dtolnay