compiletest: print the correct basename of the src dir #44630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Does this close #40712? |
laumann
reviewed
Sep 16, 2017
src/tools/compiletest/src/main.rs
Outdated
| @@ -517,7 +517,7 @@ pub fn make_test_name(config: &Config, testpaths: &TestPaths) -> test::TestName | |||
| // | |||
| // run-pass/foo/bar/baz.rs | |||
| let path = | |||
| PathBuf::from(config.mode.to_string()) | |||
| PathBuf::from(config.src_base.file_name().unwrap()); | |||
There was a problem hiding this comment.
config.src_base is already a PathBuf so wouldn't it suffice to just write config.src_base?
There was a problem hiding this comment.
That will print the absolute path to the test. I wanted to make it relative to the current working directory, and this is the crude approximation I ended up with.
|
@kennytm Yes I think it does. |
RalfJung
changed the title
RalfJung
force-pushed
the
compiletest
branch
from
c4e47ef to
83589f2
Compare
|
@bors r+ |
|
📌 Commit 83589f2 has been approved by |
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixes rust-lang#40712
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixes rust-lang#40712
TimNN
added a commit
to TimNN/rust
that referenced
this pull request
Sep 17, 2017
…crum compiletest: print the correct basename of the src dir See <Manishearth/compiletest-rs#76>. Fixes rust-lang#40712
bors
added a commit
that referenced
this pull request
Sep 17, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Manishearth/compiletest-rs#76.
Fixes #40712