Upgrade jemalloc to 5.0.1 #45163

sfackler · 2017-10-10T04:11:00Z

The build script needs to run autoconf which should be fine, right?

We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top.

sfackler · 2017-10-10T04:27:38Z

Ok, so it looks like requiring autoconf is a problem. I've pushed an extra commit de-ignoring the config file and check it in.

alexcrichton · 2017-10-10T14:10:44Z

@bors: r+

bors · 2017-10-10T14:10:45Z

📌 Commit e684700 has been approved by alexcrichton

bors · 2017-10-11T01:50:20Z

⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge 2d9a88b19fc83655778c7a4ea2d8c9106c4cb362...

bors · 2017-10-11T01:58:15Z

💔 Test failed - status-travis

sfackler · 2017-10-11T05:00:07Z

@bors retry

bors · 2017-10-11T05:08:55Z

⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge a6847a179074e0533cb52ec9d2651bc724870aa7...

bors · 2017-10-11T05:18:11Z

💔 Test failed - status-travis

kennytm · 2017-10-11T06:42:30Z

There is no O_CLOEXEC?

[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/pages.c: In function 'os_overcommits_proc':
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/pages.c:357:6: error: 'O_CLOEXEC' undeclared (first use in this function)
[00:02:12]       O_CLOEXEC);
[00:02:12]       ^
...
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/prof.c: In function 'prof_open_maps':
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/prof.c:1412:34: error: 'O_CLOEXEC' undeclared (first use in this function)
[00:02:12]   mfd = open(filename, O_RDONLY | O_CLOEXEC);
[00:02:12]                                   ^

sfackler · 2017-10-11T15:40:10Z

We build dists on a version of Linux from before CLOEXEC was created. Jemalloc's dev branch has a patch to deal with this but it's not in 5.0.1: jemalloc/jemalloc@0975b88.

Hopefully it applies cleanly.

sfackler · 2017-10-11T15:59:16Z

@bors retry

sfackler · 2017-10-11T16:41:23Z

@bors r=alexcrichton

bors · 2017-10-11T16:41:24Z

📌 Commit 4f65e18 has been approved by alexcrichton

kennytm · 2017-10-11T19:50:39Z

@bors r-

Build failed on android, some problem with the TLS section. (Travis log: https://travis-ci.org/rust-lang/rust/jobs/286655880)

[00:44:38] /checkout/src/liballoc_jemalloc/../jemalloc/src/tsd.c:20:35: error: __emutls_t.tsd_tls causes a section type conflict with tsd_tls
[00:44:38]  __thread tsd_t JEMALLOC_TLS_MODEL tsd_tls = TSD_INITIALIZER;
[00:44:38]                                    ^
[00:44:38] /checkout/src/liballoc_jemalloc/../jemalloc/src/tsd.c:20:35: note: 'tsd_tls' was declared here
[00:44:38] make: *** [src/tsd.sym.o] Error 1
[00:44:38] make: *** Waiting for unfinished jobs....
[00:44:38] 
[00:44:38] �[m�[m�[33m�[1mwarning:�[m build failed, waiting for other jobs to finish...
[00:44:41] �[m�[m�[31m�[1merror:�[m build failed
[00:44:41] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:44:41] expected success, got: exit code: 101', /checkout/src/bootstrap/compile.rs:883:8
[00:44:41] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:44:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --target arm-linux-androideabi,armv7-linux-androideabi,i686-linux-android,aarch64-linux-android,x86_64-linux-android
[00:44:41] Build completed unsuccessfully in 0:42:32

sfackler · 2017-10-12T03:26:56Z

@bors try

bors · 2017-10-12T03:27:08Z

⌛ Trying commit 1b576406f6506d0849f7f98097d7ea3ecd2750ae with merge a1559cfb4c9081f1911cb70385a14083c144e93c...

bors · 2017-10-12T03:35:00Z

💔 Test failed - status-travis

sfackler · 2017-10-12T03:55:57Z

@bors try

bors · 2017-10-12T03:56:07Z

⌛ Trying commit 1d78cc2 with merge 116157c...

@alexcrichton

Upgrade jemalloc to 5.0.1 The build script needs to run autoconf which should be fine, right? We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top. r? @alexcrichton

sfackler · 2017-10-12T06:01:22Z

@bors r=alexcrichton

bors · 2017-10-12T06:01:22Z

📌 Commit 648e44f has been approved by alexcrichton

[WIP] Rollup of 10 pull requests - Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231 - Failed merges: #45138

kennytm · 2017-10-12T19:59:25Z

Looks like this still have issues on Android, causing the compiled program sometimes segfault. Travis logs:

sfackler · 2017-10-12T20:46:03Z

Grr, ok thanks.

sfackler · 2017-10-13T15:48:59Z

I'm going to close this since I don't really want to figure out how to get the Android setup working.

rust-highfive assigned alexcrichton Oct 10, 2017

sfackler force-pushed the jemalloc-5 branch from 0660b9e to e684700 Compare October 10, 2017 04:27

sfackler force-pushed the jemalloc-5 branch from e684700 to 4f65e18 Compare October 11, 2017 15:55

kennytm mentioned this pull request Oct 11, 2017

Rollup of 8 pull requests #45207

Closed

sfackler force-pushed the jemalloc-5 branch from 4f65e18 to 1b57640 Compare October 12, 2017 03:04

sfackler force-pushed the jemalloc-5 branch from 1b57640 to b083011 Compare October 12, 2017 03:36

Upgrade jemalloc to 5.0.1

648e44f

sfackler force-pushed the jemalloc-5 branch from 1d78cc2 to 648e44f Compare October 12, 2017 05:00

kennytm mentioned this pull request Oct 12, 2017

Rollup of 9 pull requests #45233

Merged

aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017

bors added a commit that referenced this pull request Oct 12, 2017

Auto merge of #45233 - kennytm:rollup, r=<try>

6f8b325

[WIP] Rollup of 10 pull requests - Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231 - Failed merges: #45138

sfackler closed this Oct 13, 2017

sfackler deleted the jemalloc-5 branch October 13, 2017 15:49

michaelfairley mentioned this pull request Oct 13, 2017

jemalloc in 1.21.0 doesn't work on iOS #45262

Closed

SimonSapin mentioned this pull request Apr 15, 2018

Update jemalloc to 5.0.1 gnzlbg/jemallocator#34

Merged

gnzlbg mentioned this pull request Apr 15, 2018

5.0.1 fails to build on Android? jemalloc/jemalloc#1175

Open

Upgrade jemalloc to 5.0.1 #45163

Upgrade jemalloc to 5.0.1 #45163

Conversation

sfackler commented Oct 10, 2017

Uh oh!

sfackler commented Oct 10, 2017

Uh oh!

alexcrichton commented Oct 10, 2017

Uh oh!

bors commented Oct 10, 2017

Uh oh!

bors commented Oct 11, 2017

Uh oh!

bors commented Oct 11, 2017

Uh oh!

sfackler commented Oct 11, 2017

Uh oh!

bors commented Oct 11, 2017

Uh oh!

bors commented Oct 11, 2017

Uh oh!

kennytm commented Oct 11, 2017

Uh oh!

sfackler commented Oct 11, 2017

Uh oh!

sfackler commented Oct 11, 2017

Uh oh!

sfackler commented Oct 11, 2017

Uh oh!

bors commented Oct 11, 2017

Uh oh!

kennytm commented Oct 11, 2017

Uh oh!

sfackler commented Oct 12, 2017

Uh oh!

bors commented Oct 12, 2017

Uh oh!

bors commented Oct 12, 2017

Uh oh!

sfackler commented Oct 12, 2017

Uh oh!

bors commented Oct 12, 2017

Uh oh!

sfackler commented Oct 12, 2017

Uh oh!

bors commented Oct 12, 2017

Uh oh!

kennytm commented Oct 12, 2017

Uh oh!

sfackler commented Oct 12, 2017

Uh oh!

sfackler commented Oct 13, 2017

Uh oh!

Uh oh!