Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Inline eq_slice into str::eq #45005

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Inline eq_slice into str::eq #45005

merged 1 commit into from
Oct 13, 2017

Conversation

leoyvens
Copy link
Contributor

@leoyvens leoyvens commented Oct 3, 2017

It's the only use of the function.

@leoyvens
Inline eq_slice into str::eq
bb74c20 
It's the only use of the function.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs
Copy link
Member

aidanhs commented Oct 5, 2017

Thanks for the PR @leodasvacas! We'll check in now and again to make sure @aturon or another reviewer gets to this soon.

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2017
@carols10cents
Copy link
Member

Actually, @aturon is on PTO this week, so let's try....

r? @jseyfried

@rust-highfive rust-highfive assigned jseyfried and unassigned aturon Oct 9, 2017
@jseyfried
Copy link
Contributor

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Oct 11, 2017

📌 Commit bb74c20 has been approved by jseyfried

@bors
Copy link
Contributor

bors commented Oct 11, 2017

⌛ Testing commit bb74c20 with merge 503a4ffd1a4e589e5304dcf073561e87f5d164b6...

@bors
Copy link
Contributor

bors commented Oct 11, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

@bors retry

@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 11, 2017
@kennytm
Rollup merge of rust-lang#45005 - leodasvacas:inline-eq-slice-into-eq…
4f6d24e 
…, r=jseyfried

Inline eq_slice into str::eq

It's the only use of the function.
kennytm added a commit to kennytm/rust that referenced this pull request Oct 11, 2017
@kennytm
Rollup merge of rust-lang#45005 - leodasvacas:inline-eq-slice-into-eq…
17cacc8 
…, r=jseyfried

Inline eq_slice into str::eq

It's the only use of the function.
@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
@kennytm kennytm mentioned this pull request Oct 12, 2017
Merged
@petrochenkov
Copy link
Contributor

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45005 - leodasvacas:inline-eq-slice-into-eq…
4f83c35 
…, r=jseyfried

Inline eq_slice into str::eq

It's the only use of the function.
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=<try>
6f8b325 
[WIP] Rollup of 10 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=kennytm
64ee7d1 
Rollup of 9 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45166, #45172, #45190, #45231
- Failed merges: #45138
@bors bors merged commit bb74c20 into rust-lang:master Oct 13, 2017
@leoyvens leoyvens deleted the inline-eq-slice-into-eq branch March 7, 2018 10:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jseyfried jseyfried

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@leoyvens @rust-highfive @aidanhs @carols10cents @jseyfried @bors @kennytm @petrochenkov @shepmaster @aturon