Rollup of 9 pull requests #45204
Closed
Rollup of 9 pull requests #45204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's the only use of the function.
Brings in a bugfix to be compatible with the master branch of `make` where jobserver fds are set in nonblocking mode
…ng#44433. The main goal here is to use FreeBSD's normal libc++, instead of statically linking the libstdc++ packaged with GCC, because that libstdc++ has bugs that cause rustc to deadlock inside LLVM. But the easiest way to use libc++ is to switch the build from GCC to Clang, and the Clang package in the Ubuntu image already knows how to cross-compile (given a sysroot and preferably cross-binutils), so the toolchain script now uses that instead of building a custom compiler. This also de-duplicates the `build-toolchain.sh` script.
Paths to object files generated from them were too long and caused errors
output message is shown in another 'help:' block line with +100 columns formatted test adjusted
…, r=jseyfried Inline eq_slice into str::eq It's the only use of the function.
…ackler Update the `jobserver` crate Brings in a bugfix to be compatible with the master branch of `make` where jobserver fds are set in nonblocking mode
…chton Re-do the FreeBSD cross-builds to use Clang and libc++. Fixes rust-lang#44433. The main goal here is to use FreeBSD's normal libc++, instead of statically linking the libstdc++ packaged with GCC, because that libstdc++ has bugs that cause rustc to deadlock inside LLVM. But the easiest way to use libc++ is to switch the build from GCC to Clang, and the Clang package in the Ubuntu image already knows how to cross-compile (given a sysroot and preferably cross-binutils), so the toolchain script now uses that instead of building a custom compiler. This also de-duplicates the `build-toolchain.sh` script.
Fix rustc documentation typo I'm new to rustc but this looks like a typo.
…ichton Fix PEP8 style issues in bootstrap code This fixes PEP8 style issues (other than line-length) in the bootstrap Python code. The most important fix is in the `set` function where the code was indented with 6 spaces instead of 4.
Better compile error output when using arguments instead of types Following @estebank sugestion on issue rust-lang#18945 (comment)
…labnik Documented a few more unstable feature gates. unboxed closures, fn_traits, and OIBIT. hope these are decent!
Shorten some test names An immediate fix for the first issue in rust-lang#45103 r? @alexcrichton
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=9 |
|
📌 Commit 31bed4a has been approved by |
Prevent fmt::Arguments from being shared across threads Fixes rust-lang#45197 This is a **breaking change**! Without doing this it's very easy to create race conditions. There's probably a way to do this without breaking valid use cases, but it would require quite an overhaul of the formatting machinery.
|
📌 Commit b03a244 has been approved by |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobservercrate #45049, Re-do the FreeBSD cross-builds to use Clang and libc++. Fixes #44433. #45077, Fix rustc documentation typo #45105, Fix PEP8 style issues in bootstrap code #45121, Better compile error output when using arguments instead of types #45122, Documented a few more unstable feature gates. #45166, Shorten some test names #45190, Prevent fmt::Arguments from being shared across threads #45198