Skip to content

rustbuild: Prevent spurious rebuilds of the RLS #45236

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

rustbuild: Prevent spurious rebuilds of the RLS #45236

merged 1 commit into from
Oct 13, 2017

Conversation

alexcrichton
Copy link
Member

The RLS currently is rebuilt every time you test it because the OPENSSL_DIR
env var is changing, which is in turn caused by an accidental omission of
prepare_tool_cargo when testing the RLS.

@alexcrichton
rustbuild: Prevent spurious rebuilds of the RLS
e6da40c 
The RLS currently is rebuilt every time you test it because the `OPENSSL_DIR`
env var is changing, which is in turn caused by an accidental omission of
`prepare_tool_cargo` when testing the RLS.
@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2017

📌 Commit e6da40c has been approved by Mark-Simulacrum

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 13, 2017
@kennytm
Rollup merge of rust-lang#45236 - alexcrichton:build-less, r=Mark-Sim…
4ed348e 
…ulacrum

rustbuild: Prevent spurious rebuilds of the RLS

The RLS currently is rebuilt every time you test it because the `OPENSSL_DIR`
env var is changing, which is in turn caused by an accidental omission of
`prepare_tool_cargo` when testing the RLS.
@kennytm kennytm mentioned this pull request Oct 13, 2017
Merged
bors added a commit that referenced this pull request Oct 13, 2017
@bors
Auto merge of #45261 - kennytm:rollup, r=kennytm
6cb49d2 
Rollup of 14 pull requests

- Successful merges: #44855, #45110, #45122, #45133, #45173, #45178, #45189, #45203, #45209, #45221, #45236, #45240, #45245, #45253
- Failed merges:
@bors bors merged commit e6da40c into rust-lang:master Oct 13, 2017
@alexcrichton alexcrichton deleted the build-less branch October 14, 2017 02:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @Mark-Simulacrum @bors @kennytm @aturon