Skip to content

Clarify how needs_drop is conservative #45253

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

Clarify how needs_drop is conservative #45253

merged 1 commit into from
Oct 13, 2017

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Oct 13, 2017

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2017
@kennytm
Copy link
Member

kennytm commented Oct 13, 2017

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2017

📌 Commit 11775ab has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 13, 2017
@kennytm
Rollup merge of rust-lang#45253 - Gankro:drop_docs, r=kennytm
8ea6790 
Clarify how needs_drop is conservative
@kennytm kennytm mentioned this pull request Oct 13, 2017
Merged
bors added a commit that referenced this pull request Oct 13, 2017
@bors
Auto merge of #45261 - kennytm:rollup, r=kennytm
6cb49d2 
Rollup of 14 pull requests

- Successful merges: #44855, #45110, #45122, #45133, #45173, #45178, #45189, #45203, #45209, #45221, #45236, #45240, #45245, #45253
- Failed merges:
@bors bors merged commit 11775ab into rust-lang:master Oct 13, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gankra @rust-highfive @kennytm @bors @aturon