Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Stablize RefCell::{replace, swap} #46517

Merged
merged 3 commits into from
Dec 20, 2017
Merged

Stablize RefCell::{replace, swap} #46517

merged 3 commits into from
Dec 20, 2017

Conversation

notriddle
Copy link
Contributor

RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.

CC #43570

@notriddle
Stablize RefCell::{replace, swap}
fd064e0 
RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.
@rust-highfive
Copy link
Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Dec 5, 2017
@aidanhs
Copy link
Member

aidanhs commented Dec 5, 2017

r? @BurntSushi

@rust-highfive rust-highfive assigned BurntSushi and unassigned aidanhs Dec 5, 2017
@BurntSushi
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Dec 5, 2017 •
edited by aturon
Loading

Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 5, 2017
@BurntSushi BurntSushi added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2017
@Mark-Simulacrum
Copy link
Member 

[00:03:57] tidy error: /checkout/src/libcore/cell.rs:619: mismatches to previous in: ["stability level", "since", "tracking issue"]
[00:03:57] tidy error: /checkout/src/libcore/cell.rs:646: mismatches to previous in: ["stability level", "since", "tracking issue"]

@notriddle
Move replace_with to its own feature flag
28a19bf 
I'm not allowed to have the same feature flag associated with multiple stability levels.
dtolnay
dtolnay requested changes Dec 5, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when we stabilize part of a library feature, we pick a new name for the stabilized part and keep the old feature name for the remaining unstable part. This minimizes nightly breakage for code that is currently calling replace_with.

@kennytm
Copy link
Member

kennytm commented Dec 13, 2017

Ping @aturon for ticky boxes here!

@rfcbot
Copy link

rfcbot commented Dec 19, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Dec 19, 2017
@notriddle
Copy link
Contributor Author

@dtolnay I fixed the feature flags to work the way you asked.

@alexcrichton
Copy link
Member

@bors: r=BurntSushi

@bors
Copy link
Contributor

bors commented Dec 19, 2017

📌 Commit 19775f7 has been approved by BurntSushi

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Dec 20, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46517 - notriddle:patch-2, r=BurntSushi
c3241b5 
Stablize RefCell::{replace, swap}

RefCell::replace_with is not stablized in this PR, since it wasn't part of the RFC.

CC rust-lang#43570
@kennytm kennytm mentioned this pull request Dec 20, 2017
Merged
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of #46874 - kennytm:rollup, r=kennytm
81622c6 
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors
Copy link
Contributor

bors commented Dec 20, 2017

⌛ Testing commit 19775f7 with merge 81622c6...

@bors bors merged commit 19775f7 into rust-lang:master Dec 20, 2017
@notriddle notriddle deleted the patch-2 branch December 20, 2017 17:42
@ErichDonGubler ErichDonGubler mentioned this pull request Dec 29, 2017
Open
7 tasks
@alexcrichton alexcrichton mentioned this pull request Mar 1, 2018
Closed
3 tasks
@csssuf csssuf mentioned this pull request Apr 10, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

Assignees

@BurntSushi BurntSushi

Labels
final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@notriddle @rust-highfive @aidanhs @BurntSushi @rfcbot @Mark-Simulacrum @kennytm @alexcrichton @bors @dtolnay