Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Always Debug floats with a decimal point #46831

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Always Debug floats with a decimal point #46831

merged 1 commit into from
Dec 20, 2017

Conversation

Diggsey
Copy link
Contributor

@Diggsey Diggsey commented Dec 18, 2017

Fixes #30967

r? @dtolnay

@estebank
Copy link
Contributor

You'll need to update these two lines:

https://github.com/rust-lang/rust/blob/master/src/test/run-pass/ifmt.rs#L161-L162

@dtolnay dtolnay added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 19, 2017
dtolnay
dtolnay approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Dec 19, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2017

📌 Commit 3e98f18 has been approved by dtolnay

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 19, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46831 - Diggsey:float-debug-fmt, r=dtolnay
16095b3 
Always `Debug` floats with a decimal point

Fixes rust-lang#30967

r? @dtolnay
@kennytm kennytm mentioned this pull request Dec 20, 2017
Merged
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of #46874 - kennytm:rollup, r=kennytm
81622c6 
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors bors merged commit 3e98f18 into rust-lang:master Dec 20, 2017
@Diggsey Diggsey deleted the float-debug-fmt branch December 27, 2017 01:32
@dtolnay dtolnay mentioned this pull request Jan 21, 2018
Closed
@scottmcm scottmcm mentioned this pull request Apr 2, 2018
Open
@ExpHP ExpHP mentioned this pull request Jan 19, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Diggsey @estebank @dtolnay @bors @kennytm