Skip to content

LLVM5: Update DW_OP_plus to DW_OP_plus_uconst #47610

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 20, 2018

LLVM <= 4.0 used a non-standard interpretation of DW_OP_plus. In the
DWARF standard, this adds two items on the expressions stack. LLVM's
behavior was more like DWARF's DW_OP_plus_uconst -- adding a constant
that follows the op. The patch series starting with D33892 switched
to the standard DWARF interpretation, so we need to follow.

Fixes #47464
r? @eddyb

LLVM <= 4.0 used a non-standard interpretation of `DW_OP_plus`.  In the
DWARF standard, this adds two items on the expressions stack.  LLVM's
behavior was more like DWARF's `DW_OP_plus_uconst` -- adding a constant
that follows the op.  The patch series starting with [D33892] switched
to the standard DWARF interpretation, so we need to follow.

[D33892]: https://reviews.llvm.org/D33892
@cuviper cuviper mentioned this pull request Jan 20, 2018
43 tasks
@eddyb
Copy link
Member

eddyb commented Jan 20, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 20, 2018

📌 Commit e2f6b28 has been approved by eddyb

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 20, 2018
@shepmaster
Copy link
Member

@bors retry

kennytm added a commit to kennytm/rust that referenced this pull request Jan 23, 2018
LLVM5: Update DW_OP_plus to DW_OP_plus_uconst

LLVM <= 4.0 used a non-standard interpretation of `DW_OP_plus`.  In the
DWARF standard, this adds two items on the expressions stack.  LLVM's
behavior was more like DWARF's `DW_OP_plus_uconst` -- adding a constant
that follows the op.  The patch series starting with [D33892] switched
to the standard DWARF interpretation, so we need to follow.

[D33892]: https://reviews.llvm.org/D33892

Fixes rust-lang#47464
r? @eddyb
bors added a commit that referenced this pull request Jan 23, 2018
Rollup of 14 pull requests

- Successful merges: #47423, #47425, #47440, #47541, #47549, #47554, #47558, #47610, #47635, #47655, #47661, #47662, #47667, #47672
- Failed merges:
@bors bors merged commit e2f6b28 into rust-lang:master Jan 23, 2018
@cuviper cuviper deleted the captured-dwarf branch January 26, 2018 21:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants