Skip to content

Inline some rustc_driver function #47661

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Inline some rustc_driver function #47661

merged 1 commit into from
Jan 23, 2018

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 22, 2018

No description provided.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister
Copy link
Member

Thanks, @bjorn3!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 22, 2018

📌 Commit c3fabce has been approved by michaelwoerister

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 22, 2018
@kennytm kennytm mentioned this pull request Jan 23, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Jan 23, 2018
@kennytm
Rollup merge of rust-lang#47661 - bjorn3:refactor_driver, r=michaelwo…
6dcaa0a 
…erister

Inline some rustc_driver function
bors added a commit that referenced this pull request Jan 23, 2018
@bors
Auto merge of #47678 - kennytm:rollup, r=kennytm
4e3901d 
Rollup of 14 pull requests

- Successful merges: #47423, #47425, #47440, #47541, #47549, #47554, #47558, #47610, #47635, #47655, #47661, #47662, #47667, #47672
- Failed merges:
@bors bors merged commit c3fabce into rust-lang:master Jan 23, 2018
alessandrod added a commit to alessandrod/rls-rustc that referenced this pull request Jan 24, 2018
@alessandrod
Fix compilation with rustc 1.25.0-nightly (4e3901d35 2018-01-23)
de51775 
rustc_driver::get_args is no more, see
rust-lang/rust#47661.
@alessandrod alessandrod mentioned this pull request Jan 24, 2018
Merged
@nrc nrc added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2018
@nrc
Copy link
Member

nrc commented Jan 24, 2018

@rust-lang/compiler is there some motivation for these changes?

Please bear in mind that the driver for rustc is a public API and is used by a number of tools. I realise we haven't committed to stability here, but we shouldn't be landing random 'tidying up' changes which change the API. Breaking changes are fine, but they should be well-motivated.

@michaelwoerister
Copy link
Member

Sorry, I overlooked that this also included a public function. We can revert this if it broke something.

eddyb
eddyb reviewed Jan 24, 2018
View reviewed changes
src/librustc_driver/lib.rs
@@ -1329,20 +1325,19 @@ pub fn diagnostics_registry() -> errors::registry::Registry {
Registry::new(&all_errors)
}

pub fn get_args() -> Vec<String> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc I assume you mean only this function? This seems very useful, I guess because of the use of early_error this can't be substituted with anything in std directly.

@nikomatsakis
Copy link
Contributor

Seems like we might as well just roll this back -- or at least preserve the public API.

@bjorn3 bjorn3 deleted the refactor_driver branch July 10, 2019 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eddyb eddyb eddyb left review comments

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bjorn3 @rust-highfive @michaelwoerister @bors @nrc @nikomatsakis @eddyb @carols10cents