Skip to content

derive PartialEq and Eq for ParseCharError #47790

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2018
Merged

derive PartialEq and Eq for ParseCharError #47790

merged 1 commit into from
Feb 10, 2018

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Jan 26, 2018

unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason

@tinaun
derive PartialEq and Eq for ParseCharError
838ddbf 
unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2018
@kennytm
Copy link
Member

kennytm commented Jan 31, 2018

Review ping @sfackler!

@pietroalbini
Copy link
Member

@sfackler this PR awaits your review :)

@sfackler
Copy link
Member

sfackler commented Feb 9, 2018

Oops, sorry about the delay!

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 9, 2018

📌 Commit 838ddbf has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2018
@kennytm
Copy link
Member

kennytm commented Feb 9, 2018

@bors rollup

@kennytm kennytm mentioned this pull request Feb 9, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge of rust-lang#47790 - tinaun:patch-1, r=sfackler
2e28f98 
derive PartialEq and Eq for `ParseCharError`

unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48077 - kennytm:rollup, r=kennytm
68df9d6 
Rollup of 12 pull requests

- Successful merges: #47835, #47854, #48015, #48047, #48051, #48058, #48064, #47790, #48059, #48078, #48080, #48085
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 9, 2018
@kennytm
Rollup merge of rust-lang#47790 - tinaun:patch-1, r=sfackler
270e6aa 
derive PartialEq and Eq for `ParseCharError`

unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@kennytm kennytm mentioned this pull request Feb 9, 2018
Closed
bors added a commit that referenced this pull request Feb 9, 2018
@bors
Auto merge of #48104 - kennytm:rollup, r=kennytm
394ccaf 
Rollup of 17 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48085, #48086, #48090, #48093, #48098, #48101
- Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Feb 10, 2018
@kennytm
Rollup merge of rust-lang#47790 - tinaun:patch-1, r=sfackler
6bbee8d 
derive PartialEq and Eq for `ParseCharError`

unlike the other Parse*Error types, ParseCharError didn't have these implemented for whatever reason
@kennytm kennytm mentioned this pull request Feb 10, 2018
Merged
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
d5e3164 
Rollup of 16 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100
- Failed merges:
bors added a commit that referenced this pull request Feb 10, 2018
@bors
Auto merge of #48113 - kennytm:rollup, r=kennytm
45fba43 
Rollup of 20 pull requests

- Successful merges: #47790, #47835, #47854, #48015, #48047, #48051, #48058, #48059, #48064, #48078, #48080, #48086, #48098, #48101, #48107, #48100, #48085, #48120, #48124, #47547
- Failed merges:
@bors bors merged commit 838ddbf into rust-lang:master Feb 10, 2018
@tinaun tinaun deleted the patch-1 branch February 10, 2018 23:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tinaun @rust-highfive @kennytm @pietroalbini @sfackler @bors